Commit bcc20e4
authored
Correctly populate metric values for each commit (#6991)
This table shows the raw data from each commit / workflow / job that the
dashboard uses to draw the chart. However, it screwed up when the same
metric appears multiple times on one commit.
For example, there are four `median_itl_ms` metrics on vLLM dashboard
for each commit, one for each qps `[1, 4, 16, inf]`, while there is only
one latency metric on the commit. On the
[dashboard](https://hud.pytorch.org/benchmark/llms?startTime=Fri%2C%2001%20Aug%202025%2023%3A34%3A26%20GMT&stopTime=Fri%2C%2008%20Aug%202025%2023%3A34%3A26%20GMT&granularity=hour&lBranch=main&lCommit=b2c8ce57c68db0764a49d66f048b8a7a5cef9d13&rBranch=main&rCommit=808a7b69df479b6b3a16181711cac7ca28a9b941&repoName=vllm-project%2Fvllm&benchmarkName=&modelName=meta-llama%2FLlama-4-Scout-17B-16E-Instruct&backendName=All%20Backends&modeName=All%20Modes&dtypeName=All%20DType&deviceName=cuda%20(NVIDIA%20H100%2080GB%20HBM3)&archName=All%20Platforms)
showed 2 latency values on the top 2 rows. This was wrong because these
2 values were from 2 commits. The rest of the column was empty:
<img width="2453" height="146" alt="Screenshot 2025-08-08 at 17 16 32"
src="https://github.com/user-attachments/assets/6ce30050-0fd4-4995-b903-c155cdb0d2d0"
/>
The [correct
table](https://torchci-git-fork-huydhn-fix-data-details-table-fbopensource.vercel.app/benchmark/llms?startTime=Fri%2C%2001%20Aug%202025%2023%3A34%3A26%20GMT&stopTime=Fri%2C%2008%20Aug%202025%2023%3A34%3A26%20GMT&granularity=hour&lBranch=main&lCommit=b2c8ce57c68db0764a49d66f048b8a7a5cef9d13&rBranch=main&rCommit=808a7b69df479b6b3a16181711cac7ca28a9b941&repoName=vllm-project%2Fvllm&benchmarkName=&modelName=meta-llama%2FLlama-4-Scout-17B-16E-Instruct&backendName=All%20Backends&modeName=All%20Modes&dtypeName=All%20DType&deviceName=cuda%20(NVIDIA%20H100%2080GB%20HBM3)&archName=All%20Platforms)
should show the correct values for each commit:
<img width="2326" height="147" alt="Screenshot 2025-08-08 at 17 35 17"
src="https://github.com/user-attachments/assets/e1c98e4c-9dc9-4b8c-9246-3d51c5bed2f3"
/>
### Testing
[Preview with the correct value for each
commit](https://torchci-git-fork-huydhn-fix-data-details-table-fbopensource.vercel.app/benchmark/llms?startTime=Fri%2C%2001%20Aug%202025%2023%3A34%3A26%20GMT&stopTime=Fri%2C%2008%20Aug%202025%2023%3A34%3A26%20GMT&granularity=hour&lBranch=main&lCommit=b2c8ce57c68db0764a49d66f048b8a7a5cef9d13&rBranch=main&rCommit=808a7b69df479b6b3a16181711cac7ca28a9b941&repoName=vllm-project%2Fvllm&benchmarkName=&modelName=meta-llama%2FLlama-4-Scout-17B-16E-Instruct&backendName=All%20Backends&modeName=All%20Modes&dtypeName=All%20DType&deviceName=cuda%20(NVIDIA%20H100%2080GB%20HBM3)&archName=All%20Platforms)
Signed-off-by: Huy Do <huydhn@gmail.com>1 parent c61852d commit bcc20e4
1 file changed
Lines changed: 29 additions & 6 deletions
Lines changed: 29 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
360 | 360 | | |
361 | 361 | | |
362 | 362 | | |
363 | | - | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
364 | 374 | | |
365 | 375 | | |
366 | 376 | | |
| |||
437 | 447 | | |
438 | 448 | | |
439 | 449 | | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
445 | 468 | | |
446 | 469 | | |
447 | 470 | | |
| |||
0 commit comments