[BE] Cleanup split-build logic

Author: atalman

.github/workflows/generate_binary_build_matrix.yml

@@ -52,13 +52,6 @@ on:
         description: "A JSON-encoded list of python versions to build. An empty list means building all supported versions"
         default: "[]"
         type: string
-      use_split_build:
-        description: |
-          [Experimental] Build a libtorch only wheel and build pytorch such that
-          are built from the libtorch wheel.
-        required: false
-        type: boolean
-        default: false
       getting-started:
         description: "Release matrix for getting started page"
         required: false
@@ -102,7 +95,6 @@ jobs:
           # In cases when pipy binaries are not published yet.
           USE_ONLY_DL_PYTORCH_ORG: ${{ inputs.use-only-dl-pytorch-org }}
           BUILD_PYTHON_ONLY: ${{ inputs.build-python-only }}
-          USE_SPLIT_BUILD: ${{ inputs.use_split_build }}
           GETTING_STARTED: ${{ inputs.getting-started }}
           PYTHON_VERSIONS: ${{ inputs.python-versions }}
         run: |

.github/workflows/validate-binaries.yml

@@ -42,12 +42,6 @@ on:
         default: false
         required: false
         type: boolean
-      use_split_build:
-        description: |
-          [Experimental] Use Split Build
-        required: false
-        type: boolean
-        default: false
       use-extra-index-url:
         description: 'Use extra-index url for pip tests'
         default: false
@@ -101,12 +95,6 @@ on:
         default: false
         required: false
         type: boolean
-      use_split_build:
-        description: |
-          [Experimental] Use Split Build
-        required: false
-        type: boolean
-        default: false
       use-extra-index-url:
         description: 'Use extra-index url for pip tests'
         default: false
@@ -143,7 +131,6 @@ jobs:
       release-matrix: ${{ needs.generate-release-matrix.outputs.matrix }}
       include-test-ops: ${{ inputs.include-test-ops }}
       use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }}
-      use_split_build: ${{ inputs.use_split_build }}
       use-extra-index-url: ${{ inputs.use-extra-index-url }}
       use-meta-cdn: ${{ inputs.use-meta-cdn }}
 

.github/workflows/validate-linux-binaries.yml

@@ -42,12 +42,6 @@ on:
         default: false
         required: false
         type: boolean
-      use_split_build:
-        description: |
-          [Experimental] Use split build
-        required: false
-        type: boolean
-        default: false
       use-extra-index-url:
         description: 'Use extra-index url for pip tests'
         default: false
@@ -94,12 +88,6 @@ on:
         default: false
         required: false
         type: boolean
-      use_split_build:
-        description: |
-          [Experimental] Use split build
-        required: false
-        type: boolean
-        default: false
       use-extra-index-url:
         description: 'Use extra-index url for pip tests'
         default: false
@@ -119,7 +107,6 @@ jobs:
       os: linux
       channel: ${{ inputs.channel }}
       use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }}
-      use_split_build: ${{ inputs.use_split_build }}
       with-xpu: enable
 
   linux:

tools/scripts/generate_binary_build_matrix.py

@@ -275,21 +275,14 @@ def get_wheel_install_command(
     desired_cuda: str,
     python_version: str,
     use_only_dl_pytorch_org: bool,
-    use_split_build: bool = False,
     getting_started: bool = False,
 ) -> str:
     PACKAGES_TO_INSTALL = (
         PACKAGES_TO_INSTALL_GETTING_STARTED_WHL
         if getting_started
         else PACKAGES_TO_INSTALL_WHL
     )
-    if use_split_build:
-        if (gpu_arch_version in CUDA_ARCHES) and (os == LINUX) and (channel == NIGHTLY):
-            return f"{WHL_INSTALL_BASE} {PACKAGES_TO_INSTALL} --index-url {get_base_download_url_for_repo('whl', channel, gpu_arch_type, desired_cuda)}_pypi_pkg"  # noqa: E501
-        else:
-            raise ValueError(
-                "Split build is not supported for this configuration. It is only supported for CUDA 11.8, 12.4, 12.6 on Linux nightly builds."  # noqa: E501
-            )
+   
     if (
         channel == RELEASE
         and (not use_only_dl_pytorch_org)
@@ -323,7 +316,6 @@ def generate_libtorch_matrix(
     with_xpu: str,
     limit_pr_builds: bool,
     use_only_dl_pytorch_org: bool,
-    use_split_build: bool = False,
     python_versions: Optional[List[str]] = None,
     abi_versions: Optional[List[str]] = None,
     arches: Optional[List[str]] = None,
@@ -415,7 +407,6 @@ def generate_wheels_matrix(
     with_xpu: str,
     limit_pr_builds: bool,
     use_only_dl_pytorch_org: bool,
-    use_split_build: bool = False,
     getting_started: bool = False,
     python_versions: Optional[List[str]] = None,
     arches: Optional[List[str]] = None,
@@ -491,29 +482,13 @@ def generate_wheels_matrix(
                     desired_cuda,
                     python_version,
                     use_only_dl_pytorch_org,
-                    use_split_build,
                     getting_started,
                 ),
                 "channel": channel,
                 "upload_to_base_bucket": upload_to_base_bucket,
                 "stable_version": CURRENT_VERSION,
-                "use_split_build": False,
             }
             ret.append(entry)
-            if (
-                use_split_build
-                and (gpu_arch_version in CUDA_ARCHES)
-                and (os == LINUX)
-                and (channel == NIGHTLY)
-            ):
-                entry = entry.copy()
-                entry["build_name"] = (
-                    f"{package_type}-py{python_version}-{gpu_arch_type}{gpu_arch_version}-split".replace(
-                        ".", "_"
-                    )
-                )
-                entry["use_split_build"] = True
-                ret.append(entry)
 
     return ret
 
@@ -535,7 +510,6 @@ def generate_build_matrix(
     limit_pr_builds: str,
     use_only_dl_pytorch_org: str,
     build_python_only: str,
-    use_split_build: str = "false",
     getting_started: str = "false",
     python_versions: Optional[List[str]] = None,
 ) -> Dict[str, List[Dict[str, str]]]:
@@ -560,7 +534,6 @@ def generate_build_matrix(
                     with_xpu,
                     limit_pr_builds == "true",
                     use_only_dl_pytorch_org == "true",
-                    use_split_build == "true",
                     getting_started == "true",
                     python_versions,
                 )
@@ -649,14 +622,6 @@ def main(args: List[str]) -> None:
         default=os.getenv("BUILD_PYTHON_ONLY", ENABLE),
     )
 
-    parser.add_argument(
-        "--use-split-build",
-        help="Use split build for wheel",
-        type=str,
-        choices=["true", "false"],
-        default=os.getenv("USE_SPLIT_BUILD", DISABLE),
-    )
-
     parser.add_argument(
         "--getting-started",
         help="Matrix for getting started page",
@@ -693,7 +658,6 @@ def main(args: List[str]) -> None:
         options.limit_pr_builds,
         options.use_only_dl_pytorch_org,
         options.build_python_only,
-        options.use_split_build,
         options.getting_started,
         python_versions,
     )