[HUD] Add "Hide always-skipped jobs" checkbox (#7993)

As they do not provide any value whatsoever

Author: malfet

torchci/lib/JobClassifierUtil.ts

@@ -406,6 +406,9 @@ export function getGroupingData(
   // Track which jobs have failures
   const jobsWithFailures = new Set<string>();
 
+  // Track which jobs are always skipped (every recorded run was skipped)
+  const jobsAlwaysSkipped = new Set<string>();
+
   // Track which jobs are viable/strict blocking
   const jobsViableStrictBlocking = new Set<string>();
 
@@ -421,6 +424,27 @@ export function getGroupingData(
       jobsWithFailures.add(name);
     }
 
+    // A job is "always skipped" iff at least one real run exists and every
+    // real run has conclusion === 'skipped'. `nameToJobs` always has an entry
+    // per column (empty `{}` stubs for commits where the job didn't run), so
+    // we identify real runs by the presence of `id`.
+    let sawAnyJob = false;
+    let sawNonSkipped = false;
+    for (const row of shaGrid) {
+      const job = row.nameToJobs.get(name);
+      if (!job || !job.id) {
+        continue;
+      }
+      sawAnyJob = true;
+      if (job.conclusion !== JobStatus.Skipped) {
+        sawNonSkipped = true;
+        break;
+      }
+    }
+    if (sawAnyJob && !sawNonSkipped) {
+      jobsAlwaysSkipped.add(name);
+    }
+
     // Check if this job is viable/strict blocking
     if (
       repoOwner &&
@@ -455,11 +479,24 @@ export function getGroupingData(
     }
   }
 
+  // A group is "always skipped" iff every job in it is always skipped
+  const groupsAlwaysSkipped = new Set<string>();
+  for (const [groupName, jobs] of groupNameMapping.entries()) {
+    if (
+      jobs.length > 0 &&
+      jobs.every((jobName) => jobsAlwaysSkipped.has(jobName))
+    ) {
+      groupsAlwaysSkipped.add(groupName);
+    }
+  }
+
   return {
     shaGrid,
     groupNameMapping,
     jobsWithFailures,
     groupsWithFailures,
+    jobsAlwaysSkipped,
+    groupsAlwaysSkipped,
     jobsViableStrictBlocking,
     groupsViableStrictBlocking,
   };

torchci/lib/useGroupingPreference.tsx

@@ -89,3 +89,15 @@ export function useHideNonViableStrictPreference(): [
   );
   return [state, setState];
 }
+
+export function useHideAlwaysSkippedPreference(): [
+  boolean,
+  (_hideAlwaysSkippedValue: boolean) => void
+] {
+  const [state, setState] = usePreference(
+    "hideAlwaysSkipped",
+    /*override*/ undefined,
+    /*default*/ true
+  );
+  return [state, setState];
+}

torchci/pages/hud/[repoOwner]/[repoName]/[branch]/[[...page]].tsx

@@ -52,6 +52,7 @@ import {
 } from "lib/types";
 import {
   useGroupingPreference,
+  useHideAlwaysSkippedPreference,
   useHideGreenColumnsPreference,
   useHideNonViableStrictPreference,
   useMonsterFailuresPreference,
@@ -389,6 +390,8 @@ function FiltersAndSettings({}: {}) {
     useHideGreenColumnsPreference();
   const [hideNonViableStrict, setHideNonViableStrict] =
     useHideNonViableStrictPreference();
+  const [hideAlwaysSkipped, setHideAlwaysSkipped] =
+    useHideAlwaysSkippedPreference();
   const [useGrouping, setUseGrouping] = useGroupingPreference(
     params.nameFilter
   );
@@ -447,6 +450,13 @@ function FiltersAndSettings({}: {}) {
                   key="hideNonViableStrict"
                   labelText={"Hide non-viable-strict jobs"}
                 />,
+                <CheckBoxSelector
+                  value={hideAlwaysSkipped}
+                  setValue={(value) => setHideAlwaysSkipped(value)}
+                  checkBoxName="hideAlwaysSkipped"
+                  key="hideAlwaysSkipped"
+                  labelText={"Hide always-skipped jobs"}
+                />,
                 <CheckBoxSelector
                   value={mergeEphemeralLF}
                   setValue={setMergeEphemeralLF}
@@ -742,13 +752,16 @@ function GroupedHudTable({ params }: { params: HudParams }) {
   const [hideUnstable] = usePreference("hideUnstable");
   const [hideGreenColumns] = useHideGreenColumnsPreference();
   const [hideNonViableStrict] = useHideNonViableStrictPreference();
+  const [hideAlwaysSkipped] = useHideAlwaysSkippedPreference();
   const [useGrouping] = useGroupingPreference(params.nameFilter);
 
   const {
     shaGrid,
     groupNameMapping,
     jobsWithFailures,
     groupsWithFailures,
+    jobsAlwaysSkipped,
+    groupsAlwaysSkipped,
     jobsViableStrictBlocking,
     groupsViableStrictBlocking,
   } = getGroupingData(
@@ -832,6 +845,17 @@ function GroupedHudTable({ params }: { params: HudParams }) {
       }
     }
 
+    // If hiding always-skipped jobs, drop columns where every recorded run was skipped
+    if (hideAlwaysSkipped) {
+      if (groupNameMapping.has(name)) {
+        if (groupsAlwaysSkipped.has(name)) {
+          return false;
+        }
+      } else if (jobsAlwaysSkipped.has(name)) {
+        return false;
+      }
+    }
+
     // If hiding green columns, filter out names that don't have any failed jobs
     if (hideGreenColumns) {
       // For group names, check if any job in the group has failures