Skip to content

Commit d36cd11

Browse files
committed
Clarify unclassified-set comment in coverage SQL
- Reword the _SELECT_UNCLASSIFIED comment to state the verdict is keyed at the normalized-job identity /flaky_trunk joins on - Note the enumeration's unclassified set matches the page's - Spell out that evidence is narrower than the key: one shard's log backs the verdict applied to all shards of the job Comment-only change; the query itself is unchanged. Signed-off-by: Jean Schmidt <contato@jschmidt.me>
1 parent 3d90858 commit d36cd11

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

  • aws/lambda/pytorch-advisor-coverage/advisor_coverage

aws/lambda/pytorch-advisor-coverage/advisor_coverage/sql.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,12 @@
215215

216216
# One row per (commit, NORMALIZED job): the category=5 shards of a normalized job
217217
# at a commit are collapsed to the normalized name so exactly ONE advisor is
218-
# dispatched per normalized job. Its coverage_ verdict then classifies every shard
219-
# of that job at the commit (the same normalized identity /flaky_trunk joins on),
220-
# instead of one shard's verdict bleeding onto its siblings. The representative
221-
# failing run (name/job_id/log) is the latest-attempt category=5 shard.
218+
# dispatched per normalized job, keyed at the same normalized identity
219+
# /flaky_trunk joins on -- so its coverage_ verdict classifies every shard of that
220+
# job at the commit, and this enumeration's unclassified set matches the page's.
221+
# The evidence is narrower than the key: the representative failing run
222+
# (name/job_id/log) is a single latest-attempt category=5 shard, so one shard's
223+
# log backs the verdict that lands on all of them.
222224
_SELECT_UNCLASSIFIED = r"""SELECT
223225
fj.head_sha AS head_sha,
224226
any(fj.commit_time) AS commit_time,

0 commit comments

Comments
 (0)