Skip to content

Commit d698472

Browse files
authored
[BE] Clean up blueberries and dynamic (#7012)
As called out in https://fburl.com/gdoc/iqps675o, they are not looked at by PT2 oncalls anymore and can be cleaned up cc @ezyang as you originally added them ### Testing https://torchci-git-fork-huydhn-cleanup-blueberies-fbopensource.vercel.app/benchmark/compilers Signed-off-by: Huy Do <huydhn@gmail.com>
1 parent e7eb068 commit d698472

6 files changed

Lines changed: 3 additions & 105 deletions

File tree

torchci/components/benchmark/compilers/ModelGraphPanel.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ import {
1010
TimeSeriesPanelWithData,
1111
} from "components/metrics/panels/TimeSeriesPanel";
1212
import dayjs from "dayjs";
13-
import {
14-
augmentData,
15-
convertToCompilerPerformanceData,
16-
} from "lib/benchmark/compilerUtils";
13+
import { convertToCompilerPerformanceData } from "lib/benchmark/compilerUtils";
1714
import { fetcher } from "lib/GeneralUtils";
1815
import { CompilerPerformanceData } from "lib/types";
1916
import useSWR from "swr";
@@ -53,7 +50,6 @@ export function GraphPanel({
5350
refreshInterval: 60 * 60 * 1000, // refresh every hour
5451
});
5552
data = convertToCompilerPerformanceData(data);
56-
data = augmentData(data);
5753

5854
if (data === undefined || data.length === 0) {
5955
return <Skeleton variant={"rectangular"} height={"100%"} />;

torchci/components/benchmark/compilers/SuitePicker.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,12 @@ import {
66
SelectChangeEvent,
77
} from "@mui/material";
88

9-
// TODO: move to a common place
109
export const SUITES: { [k: string]: string } = {
1110
torchbench: "Torchbench",
1211
huggingface: "Huggingface",
1312
timm_models: "TIMM models",
14-
dynamic: "[Dynamic]",
15-
blueberries: "[Blueberries]",
1613
};
1714

18-
// TODO: DELETE IT
1915
export function SuitePicker({
2016
suite,
2117
setSuite,

torchci/lib/benchmark/compilerUtils.ts

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -390,80 +390,6 @@ export function computePeakMemoryUsage(
390390
return returnedMemory;
391391
}
392392

393-
// Generate extra entries for reporting purposes
394-
export function augmentData(data: CompilerPerformanceData[]) {
395-
if (data === undefined) return data;
396-
const groups: { [key: string]: { [key: string]: Set<string> } } = {
397-
dynamic: {
398-
// NB: Not all of these actually exercise dynamic shapes,
399-
// so our numbers may be over-inflated. Threats to validity
400-
// listed below. Note that in all cases they are run with
401-
// dynamic batch size, so you are at least getting some
402-
// information that way.
403-
torchbench: new Set([
404-
// _generate variants are good; they do E2E autoregressive
405-
// generation and will induce varying context length.
406-
"cm3leon_generate",
407-
"nanogpt",
408-
"hf_T5_generate",
409-
"nanogpt",
410-
// detection models are ok-ish; the good news is they call
411-
// nonzero internally and exercise dynamic shapes that way,
412-
// the bad news is we may not run enough iterations with
413-
// varying data to get varying numbers of bounding boxes.
414-
"detectron2_fcos_r_50_fpn",
415-
"vision_maskrcnn",
416-
// this recommendation model internally uses sparse tensors
417-
// but once again it's not clear that dynamic shapes is exercised
418-
// on this sparsity
419-
"dlrm",
420-
// these language models are only running a single next
421-
// word prediction, we're NOT testing dynamic sequence length
422-
// performance
423-
"llama",
424-
"BERT_pytorch",
425-
"hf_T5",
426-
// the GNN benchmarks only one run one batch so you
427-
// aren't actually triggering dynamism (and we didn't
428-
// explicitly mark something as dynamic)
429-
"basic_gnn_edgecnn",
430-
"basic_gnn_gcn",
431-
"basic_gnn_gin",
432-
"basic_gnn_sage",
433-
]),
434-
huggingface: new Set([]),
435-
},
436-
blueberries: {
437-
torchbench: new Set([
438-
"nanogpt",
439-
"llama",
440-
"llama_v2_7b_16h",
441-
"sam",
442-
"sam_fast",
443-
"clip",
444-
"stable_diffusion_text_encoder",
445-
"hf_Whisper",
446-
]),
447-
},
448-
};
449-
450-
function GenerateGroup(data: CompilerPerformanceData[], n: string) {
451-
const l = groups[n];
452-
return data
453-
.filter((e: CompilerPerformanceData) => {
454-
return e.suite in l && l[e.suite].has(e.name);
455-
})
456-
.map((e) => {
457-
return { ...e, suite: n };
458-
});
459-
}
460-
461-
return ([] as CompilerPerformanceData[]).concat(
462-
data,
463-
...Object.keys(groups).map((n) => GenerateGroup(data, n))
464-
);
465-
}
466-
467393
// Use this function to convert the generic benchmark data to the old
468394
// CompilerPerformanceData format. Maybe we can get rid of this once
469395
// we have a new UX for benchmark dashboard 2.0

torchci/lib/benchmark/compliers/CompilerSuites.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,4 @@ export const COMPILER_SUITES_MAP: { [k: string]: SuiteConfig } = {
2424
id: "timm_models",
2525
showGraph: true,
2626
},
27-
dynamic: {
28-
name: "[Dynamic]",
29-
id: "dynamic",
30-
showGraph: false,
31-
},
32-
blueberries: {
33-
name: "[Blueberries]",
34-
id: "blueberries",
35-
showGraph: false,
36-
},
3727
};

torchci/pages/benchmark/[suite]/[compiler]/[[...page]].tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,7 @@ import CopyLink from "components/common/CopyLink";
3030
import GranularityPicker from "components/common/GranularityPicker";
3131
import { Granularity } from "components/metrics/panels/TimeSeriesPanel";
3232
import dayjs from "dayjs";
33-
import {
34-
augmentData,
35-
convertToCompilerPerformanceData,
36-
} from "lib/benchmark/compilerUtils";
33+
import { convertToCompilerPerformanceData } from "lib/benchmark/compilerUtils";
3734
import { fetcher } from "lib/GeneralUtils";
3835
import { BranchAndCommit, CompilerPerformanceData } from "lib/types";
3936
import { useRouter } from "next/router";
@@ -86,7 +83,6 @@ function Report({
8683
refreshInterval: 60 * 60 * 1000, // refresh every hour
8784
});
8885
lData = convertToCompilerPerformanceData(lData);
89-
lData = augmentData(lData);
9086
lData = lData
9187
? lData.filter(
9288
(e: CompilerPerformanceData) =>
@@ -108,7 +104,6 @@ function Report({
108104
refreshInterval: 60 * 60 * 1000, // refresh every hour
109105
});
110106
rData = convertToCompilerPerformanceData(rData);
111-
rData = augmentData(rData);
112107
rData = rData
113108
? rData.filter(
114109
(e: CompilerPerformanceData) =>

torchci/pages/benchmark/compilers.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@ import CopyLink from "components/common/CopyLink";
2929
import GranularityPicker from "components/common/GranularityPicker";
3030
import { Granularity } from "components/metrics/panels/TimeSeriesPanel";
3131
import dayjs from "dayjs";
32-
import {
33-
augmentData,
34-
convertToCompilerPerformanceData,
35-
} from "lib/benchmark/compilerUtils";
32+
import { convertToCompilerPerformanceData } from "lib/benchmark/compilerUtils";
3633
import { fetcher } from "lib/GeneralUtils";
3734
import { BranchAndCommit } from "lib/types";
3835
import { useRouter } from "next/router";
@@ -80,7 +77,6 @@ function Report({
8077
refreshInterval: 60 * 60 * 1000, // refresh every hour
8178
});
8279
lData = convertToCompilerPerformanceData(lData);
83-
lData = augmentData(lData);
8480

8581
const queryParamsWithR: { [key: string]: any } = {
8682
...queryParams,
@@ -95,7 +91,6 @@ function Report({
9591
refreshInterval: 60 * 60 * 1000, // refresh every hour
9692
});
9793
rData = convertToCompilerPerformanceData(rData);
98-
rData = augmentData(rData);
9994

10095
if (
10196
lData === undefined ||

0 commit comments

Comments
 (0)