Skip to content

Commit e779b46

Browse files
committed
[HUD] Clarify Unstable jobs panel subtitle
Name the two groups the panel unions and say the marker is applied at runtime, so the subtitle doesn't read as the filed UNSTABLE issue list.
1 parent 584732c commit e779b46

2 files changed

Lines changed: 8 additions & 10 deletions

File tree

torchci/clickhouse_queries/master_commit_red_jobs/query.sql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ WITH all_jobs AS (
4545
AND j.name NOT LIKE '%filter%'
4646
AND j.name LIKE '%/%'
4747
-- Normal mode ({unstableOnly}=0): exclude unstable jobs, keep the requested
48-
-- workflows. Unstable mode ({unstableOnly}=1): the dedicated "unstable"
49-
-- workflow, plus any job marked unstable (including scheduled/nightly);
50-
-- workflowNames is unused in that mode. Both modes drop workflow_run-chained
51-
-- jobs via the shared line below.
48+
-- workflows. Unstable mode ({unstableOnly}=1): the union of the "unstable"
49+
-- workflow and jobs whose name carries the runtime unstable marker;
50+
-- workflowNames is unused there. Both modes drop workflow_run-chained jobs
51+
-- via the shared line below.
5252
AND (
5353
(
5454
{unstableOnly: UInt8} = 0

torchci/pages/reliability/[repoOwner]/[repoName]/[[...page]].tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -574,16 +574,14 @@ export default function Page() {
574574

575575
<Grid size={{ xs: 6 }} height={ROW_HEIGHT}>
576576
{/*
577-
Unstable jobs to watch: union of the dedicated "unstable" workflow and
578-
any job marked unstable on main (any trigger; workflow_run-chained jobs
579-
excluded). Same query as the other panels with unstableOnly=1, which
580-
flips its unstable filter; workflowNames is unused in that mode.
577+
Unstable jobs to watch: the union of unstable.yml and jobs whose name
578+
carries the runtime unstable marker.
581579
*/}
582580
<GroupReliabilityPanel
583581
title={"Unstable jobs"}
584582
subtitle={
585-
UNSTABLE_WORKFLOWS.join(", ") +
586-
" workflow + main jobs marked unstable"
583+
UNSTABLE_WORKFLOWS.map((w) => `${w}.yml`).join(", ") +
584+
" + jobs tagged unstable at runtime"
587585
}
588586
queryName={queryName}
589587
queryParams={{ unstableOnly: 1, ...queryParams }}

0 commit comments

Comments
 (0)