Skip to content

Commit f24341a

Browse files
authored
Use Docker Hub alpine for IDC runners in chown-directory steps (#7966)
The `linux.idc.*` runners (e.g. XPU) don't have the ECR alpine image cached and lack ECR credentials at the chown-directory cleanup stage, causing post-test failures even when all tests pass. Use the public Docker Hub alpine image for these runners, matching the existing pattern for `linux.arm64` runners. I hit this when trying to get XPU workflows going on Kineto: pytorch/kineto#1302
1 parent 6527020 commit f24341a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/linux_job_v2.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,13 +308,13 @@ jobs:
308308
uses: ./test-infra/.github/actions/chown-directory
309309
with:
310310
directory: ${{ github.workspace }}/${{ env.repository }}
311-
ALPINE_IMAGE: ${{ startsWith(inputs.runner, 'linux.arm64') && 'arm64v8/alpine' || '308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine' }}
311+
ALPINE_IMAGE: ${{ startsWith(inputs.runner, 'linux.arm64') && 'arm64v8/alpine' || startsWith(inputs.runner, 'linux.idc') && 'alpine' || '308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine' }}
312312

313313
- name: Chown runner temp
314314
uses: ./test-infra/.github/actions/chown-directory
315315
with:
316316
directory: ${{ runner.temp }}
317-
ALPINE_IMAGE: ${{ startsWith(inputs.runner, 'linux.arm64') && 'arm64v8/alpine' || '308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine' }}
317+
ALPINE_IMAGE: ${{ startsWith(inputs.runner, 'linux.arm64') && 'arm64v8/alpine' || startsWith(inputs.runner, 'linux.idc') && 'alpine' || '308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine' }}
318318

319319
- name: Prepare artifacts for upload
320320
if: always()

0 commit comments

Comments
 (0)