Skip to content

Allow using tag prefixes in calculate-docker-image #6048

Open
@atalman

Description

Issue with discrepancy between dockerhub image names for manylinux 2_28 images and ecr images:

Current naming:
308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/manylinux2_28-builder-rocm6.2.4:804413e4d6f4e378061d47bd4ed99c1cbb462011

Proposed naming:
308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/manylinux2_28-builder:rocm6.2.4-804413e4d6f4e378061d47bd4ed99c1cbb462011
similar to
pytorch/manylinux2_28-builder:rocm6.2.4-eed9bb3a0e85082d4d95ad4fa33673a158b8c488
This will rid us of the need to request new ECR entries to be created in the internal docker registry every time there's a ROCm (or even CUDA) version update, and afaict, there'll be no loss of information.
Also, it'll sync up the two repos' naming conventions perfectly.

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

  • Status

    Cold Storage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions