Skip to content

Accept a plain payload in log-classifier - #8599

Closed
huydhn wants to merge 1 commit into
gh/huydhn/9/basefrom
gh/huydhn/9/head
Closed

Accept a plain payload in log-classifier#8599
huydhn wants to merge 1 commit into
gh/huydhn/9/basefrom
gh/huydhn/9/head

Conversation

@huydhn

@huydhn huydhn commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Impact: log_classifier, whose entrypoint moves from lambda_http to
lambda_runtime
Risk: medium -- every caller goes through this handler

What

log_classifier now accepts {"job_id": 123, "repo": "..."} in addition to the
API Gateway HTTP API v2.0 request its function URL callers send. Parameter
extraction moves into parse_request, which reads queryStringParameters, then
rawQueryString, then top-level keys, and the handler returns the same
{statusCode, headers, body, isBase64Encoded} document as before so function URL
callers see no change.

Existing callers are unaffected: backfillJobs.mjs, keep-going-call-log-classifier
and github-status-test all keep using the function URL and the v2.0 shape, which
parses_a_function_url_request pins.

[ghstack-poisoned]
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
torchci Ignored Ignored Aug 20, 2026 9:36pm

Request Review

@huydhn

huydhn commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this was scope creep on the github-status-test migration. It rewrites the entrypoint of a lambda that backfillJobs.mjs, keep-going-call-log-classifier and github-status-test all depend on, to delete ~25 lines from a lambda that isn't live yet. gha-log-uploader (#8591) keeps synthesising the v2.0 envelope, which touches nothing in production.

Still worth doing on its own: teaching log_classifier to accept a plain {job_id, repo} payload is what lets its AuthType: NONE function URL be retired, once the other three callers move off it too.

@huydhn huydhn closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant