From 8f359cb60b54d3be97552a61a51f21ddec14d2d5 Mon Sep 17 00:00:00 2001 From: atalman Date: Tue, 11 Aug 2026 11:18:44 -0700 Subject: [PATCH] [release/2.14] Pin validation to release/2.14 and bump CURRENT_CANDIDATE_VERSION Release-only follow-up to the 2.14 branch cut (79a17ecbf), porting the equivalents of #8171 / #8172 / #8216 from release/2.13. ## 1. `CURRENT_CANDIDATE_VERSION` -> 2.14.0 The branch cut moved `CURRENT_NIGHTLY_VERSION` to 2.14.0 but left `CURRENT_CANDIDATE_VERSION` at 2.13.0. For the test channel `initialize_globals()` sets `CURRENT_VERSION = CURRENT_CANDIDATE_VERSION`, which the generated matrix surfaces as `stable_version` and `smoke_test.py` then enforces. Since the test channel now serves the 2.14.0 release candidate, validation fails with: ``` RuntimeError: Torch version mismatch, expected 2.13.0 for channel test ``` Verified with `generate_binary_build_matrix.py --channel test`: `stable_version` goes 2.13.0 -> 2.14.0. `CURRENT_STABLE_VERSION` stays at 2.13.0 (the current GA release); it moves separately when 2.14 goes live. ## 2. `pytorch/pytorch` checkouts -> `ref: release/2.14` The validation jobs check out `repository: "pytorch/pytorch"` with `ref: main`, so release validation ran against main's `.ci` / `test/smoke_test` sources instead of the release branch. Pinned in all seven call sites across `validate-{linux,windows,macos-arm64,aarch64-linux}-binaries.yml` and `validate-docker-images.yml`, matching release/2.13's state. ## 3. Explicit `test-infra-ref: release/2.14` in matrix generation Belt-and-braces: the branch cut already rewrote the `test-infra-ref` default in `generate_binary_build_matrix.yml` to `release/2.14`, so this is not a live bug on 2.14 (it was on 2.13, where the default stayed `main`). Passing it explicitly keeps the matrix pinned to the release branch even if that default is ever re-synced from main. ## 4. Revert a branch-cut sed artifact The cut rewrote a comment referring to the *Poetry* project's own branch, `poetry@main` -> `poetry@release/2.14`, which is meaningless. Restored. Authored with the assistance of Claude Code. --- .github/workflows/validate-aarch64-linux-binaries.yml | 3 ++- .github/workflows/validate-docker-images.yml | 2 +- .github/workflows/validate-linux-binaries.yml | 9 +++++---- .github/workflows/validate-macos-arm64-binaries.yml | 3 ++- .github/workflows/validate-windows-binaries.yml | 3 ++- tools/scripts/generate_binary_build_matrix.py | 2 +- 6 files changed, 13 insertions(+), 9 deletions(-) diff --git a/.github/workflows/validate-aarch64-linux-binaries.yml b/.github/workflows/validate-aarch64-linux-binaries.yml index 1513fb402c..40ec701ddd 100644 --- a/.github/workflows/validate-aarch64-linux-binaries.yml +++ b/.github/workflows/validate-aarch64-linux-binaries.yml @@ -96,6 +96,7 @@ jobs: package-type: wheel os: linux-aarch64 channel: ${{ inputs.channel }} + test-infra-ref: release/2.14 with-cuda: enable with-cpu: enable use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }} @@ -110,7 +111,7 @@ jobs: with: runner: ${{ matrix.validation_runner }} repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: ${{ matrix.build_name }} docker-image: ${{ matrix.container_image }} binary-matrix: ${{ toJSON(matrix) }} diff --git a/.github/workflows/validate-docker-images.yml b/.github/workflows/validate-docker-images.yml index ded855d9c2..e6eb54a76c 100644 --- a/.github/workflows/validate-docker-images.yml +++ b/.github/workflows/validate-docker-images.yml @@ -59,7 +59,7 @@ jobs: with: runner: ${{ matrix.validation_runner }} repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: cuda${{ matrix.cuda }}-cudnn${{ matrix.cudnn_version }}-${{ matrix.image_type }} binary-matrix: ${{ toJSON(matrix) }} docker-image: ${{matrix.docker}} diff --git a/.github/workflows/validate-linux-binaries.yml b/.github/workflows/validate-linux-binaries.yml index e5af611ac0..60b7914cb9 100644 --- a/.github/workflows/validate-linux-binaries.yml +++ b/.github/workflows/validate-linux-binaries.yml @@ -106,6 +106,7 @@ jobs: package-type: wheel,libtorch os: linux channel: ${{ inputs.channel }} + test-infra-ref: release/2.14 use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }} with-xpu: enable @@ -119,7 +120,7 @@ jobs: with: runner: ${{ matrix.validation_runner }} repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: ${{ matrix.build_name }} # ROCm validates on the regular almalinux image (like CUDA) to confirm # the wheels are self-contained. Only XPU still needs its own container. @@ -145,7 +146,7 @@ jobs: # Validate binaries. Poetry-based validation now lives in the # standalone linux-poetry job below so Poetry's own ecosystem - # churn (it was previously installed from poetry@release/2.14) cannot + # churn (it was previously installed from poetry@main) cannot # flake the binary matrix. source ../../test-infra/.github/scripts/validate_binaries.sh @@ -156,7 +157,7 @@ jobs: with: runner: "linux.g5.4xlarge.nvidia.gpu" repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: "poetry-test" docker-image: 'pytorch/almalinux-builder:cpu-main' docker-build-dir: "skip-docker-build" @@ -185,7 +186,7 @@ jobs: with: runner: "linux.g5.4xlarge.nvidia.gpu" repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: "amazon-linux-2023-test" docker-image: 'almalinux/9-base' docker-build-dir: "skip-docker-build" diff --git a/.github/workflows/validate-macos-arm64-binaries.yml b/.github/workflows/validate-macos-arm64-binaries.yml index 277fc9f93b..c76ca9e878 100644 --- a/.github/workflows/validate-macos-arm64-binaries.yml +++ b/.github/workflows/validate-macos-arm64-binaries.yml @@ -96,6 +96,7 @@ jobs: package-type: wheel,libtorch # We stopped producing conda nightlies os: macos-arm64 channel: ${{ inputs.channel }} + test-infra-ref: release/2.14 use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }} macos-arm64: @@ -108,7 +109,7 @@ jobs: with: runner: ${{ matrix.validation_runner }} repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: ${{ matrix.build_name }} binary-matrix: ${{ toJSON(matrix) }} script: | diff --git a/.github/workflows/validate-windows-binaries.yml b/.github/workflows/validate-windows-binaries.yml index cb44d2cdc9..67ba9ce372 100644 --- a/.github/workflows/validate-windows-binaries.yml +++ b/.github/workflows/validate-windows-binaries.yml @@ -96,6 +96,7 @@ jobs: package-type: wheel,libtorch # We stopped producing conda nightlies os: windows channel: ${{ inputs.channel }} + test-infra-ref: release/2.14 use-only-dl-pytorch-org: ${{ inputs.use-only-dl-pytorch-org }} with-xpu: enable @@ -109,7 +110,7 @@ jobs: with: runner: ${{ matrix.package_type == 'libtorch' && 'windows.4xlarge' || matrix.validation_runner }} repository: "pytorch/pytorch" - ref: main + ref: release/2.14 job-name: ${{ matrix.build_name }} binary-matrix: ${{ toJSON(matrix) }} timeout: 60 diff --git a/tools/scripts/generate_binary_build_matrix.py b/tools/scripts/generate_binary_build_matrix.py index aff1abaa98..50293f6e58 100755 --- a/tools/scripts/generate_binary_build_matrix.py +++ b/tools/scripts/generate_binary_build_matrix.py @@ -99,7 +99,7 @@ CURRENT_NIGHTLY_VERSION = "2.14.0" -CURRENT_CANDIDATE_VERSION = "2.13.0" +CURRENT_CANDIDATE_VERSION = "2.14.0" CURRENT_STABLE_VERSION = "2.13.0" CURRENT_VERSION = CURRENT_STABLE_VERSION