Skip to content

Follow release reusables whose runner comes from _select-release-runner outputs - #8530

Merged
huydhn merged 1 commit into
mainfrom
follow-selector-output-reusables
Aug 14, 2026
Merged

Follow release reusables whose runner comes from _select-release-runner outputs#8530
huydhn merged 1 commit into
mainfrom
follow-selector-output-reusables

Conversation

@huydhn

@huydhn huydhn commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

_build-triton-wheel-linux.yml never made it into the release runner-group allow-list, so all 40 build-wheel-{cuda,aarch64,rocm,xpu} jobs in "Build Triton wheels" sat queued with runner_group_name: "" — see pytorch/pytorch run 31811475863.

collect_release_workflow_paths used two disagreeing notions of "release related":

  • Entry detection propagates the rel- signal through a local reusable, so a workflow calling _select-release-runner.yml is discovered. build-triton-wheel.yml was.
  • Edge traversal only followed a uses: when the calling job body held an inline rel- label.

pytorch/pytorch#193378 split the triton build into _build-triton-wheel-linux.yml, invoked as:

  build-wheel-cuda:
    needs: select-runner
    uses: ./.github/workflows/_build-triton-wheel-linux.yml
    with:
      runs_on: ${{ needs.select-runner.outputs.x86 }}

No inline label, so the edge was never taken and the reusable that actually consumes the release runner never reached the allow-list. _binary-build-linux.yml survived only incidentally: its generated caller still inlines the label in runs_on:.

Testing

Run locally and https://github.com/pytorch/pytorch/actions/runs/31811475863/job/94802925779 is working now

…er outputs

The runner-group allow-list dropped
pytorch/pytorch/.github/workflows/_build-triton-wheel-linux.yml, so every
build-wheel-{cuda,aarch64,rocm,xpu} job in "Build Triton wheels" queued
indefinitely with runner_group_name "" (e.g. pytorch/pytorch run 31811475863,
40 jobs stuck).

collect_release_workflow_paths used two disagreeing notions of "release
related". Entry detection propagates the rel- signal through a local reusable,
so a workflow that calls _select-release-runner.yml is discovered. Edge
traversal, though, only followed a `uses:` when the *calling job body* held an
inline rel- label. pytorch/pytorch#193378 split the triton build into
_build-triton-wheel-linux.yml, called as:

    build-wheel-cuda:
      needs: select-runner
      uses: ./.github/workflows/_build-triton-wheel-linux.yml
      with:
        runs_on: ${{ needs.select-runner.outputs.x86 }}

No inline label, so the edge was never taken and the reusable that actually
consumes the release runner never reached the allow-list. _binary-build-linux.yml
survived only because its generated caller still inlines the label in runs_on:.

Give both steps one definition of "runs on a release runner": an inline rel-
label, or a reference to the outputs of a job that calls a release-label
reusable. Sibling test/upload jobs still gate out, since they depend on the
build jobs rather than on the selector.

Dry-run against pytorch/pytorch over all seven target refs: 39 -> 40 entries,
the sole delta being _build-triton-wheel-linux.yml@refs/heads/main. Discovery on
the other six refs is unchanged, and per-ref discovery correctly omits the file
where it does not exist yet.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2026
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
torchci Ignored Ignored Aug 14, 2026 7:05pm

Request Review

@huydhn
huydhn requested a review from atalman August 14, 2026 19:23
@huydhn
huydhn marked this pull request as ready for review August 14, 2026 19:23

@atalman atalman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn
huydhn merged commit 0c006ce into main Aug 14, 2026
11 checks passed
@huydhn
huydhn deleted the follow-selector-output-reusables branch August 14, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants