Skip to content

Commit 2c4ce95

Browse files
huydhnNicolasHug
andauthored
Cherry pick #2241 and #2242 (#2244)
* Remove torchdata dependency from package and from CI (#2241) * Fix torchdata import error (#2242) * Remove stuff * stuff * lint --------- Co-authored-by: Nicolas Hug <[email protected]>
1 parent 57ed43c commit 2c4ce95

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+72
-191
lines changed

.circleci/unittest/linux/scripts/install.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#!/usr/bin/env bash
22

33
unset PYTORCH_VERSION
4-
unset TORCHDATA_VERSION
54
# For unittest, nightly PyTorch is used as the following section,
65
# so no need to set PYTORCH_VERSION.
76
# In fact, keeping PYTORCH_VERSION forces us to hardcode PyTorch version in config.
@@ -30,10 +29,6 @@ printf "* Installing PyTorch\n"
3029
)
3130

3231

33-
printf "Installing torchdata nightly with portalocker\n"
34-
pip install "portalocker>=2.0.0"
35-
pip install --pre torchdata --index-url https://download.pytorch.org/whl/nightly/cpu
36-
3732
printf "* Installing torchtext\n"
3833
python setup.py develop
3934

.circleci/unittest/windows/scripts/install.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#!/usr/bin/env bash
22

33
unset PYTORCH_VERSION
4-
unset TORCHDATA_VERSION
54
# For unittest, nightly PyTorch is used as the following section,
65
# so no need to set PYTORCH_VERSION.
76
# In fact, keeping PYTORCH_VERSION forces us to hardcode PyTorch version in config.
@@ -19,10 +18,6 @@ conda activate ./env
1918
printf "* Installing PyTorch\n"
2019
conda install -y -c "pytorch-${UPLOAD_CHANNEL}" ${CONDA_CHANNEL_FLAGS} pytorch cpuonly
2120

22-
printf "* Installing torchdata nightly with portalocker\n"
23-
pip install "portalocker>=2.0.0"
24-
pip install --pre torchdata --index-url https://download.pytorch.org/whl/nightly/cpu
25-
2621
printf "* Installing pywin32_postinstall script\n"
2722
curl --output pywin32_postinstall.py https://raw.githubusercontent.com/mhammond/pywin32/main/pywin32_postinstall.py
2823
python pywin32_postinstall.py -install

.github/workflows/build-conda-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
matrix:
3030
include:
3131
- repository: pytorch/text
32-
pre-script: packaging/install_torchdata.sh
32+
pre-script: ""
3333
post-script: ""
3434
conda-package-directory: packaging/torchtext
3535
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-conda-m1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
matrix:
2929
include:
3030
- repository: pytorch/text
31-
pre-script: packaging/install_torchdata.sh
31+
pre-script: ""
3232
post-script: ""
3333
conda-package-directory: packaging/torchtext
3434
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-conda-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
matrix:
3030
include:
3131
- repository: pytorch/text
32-
pre-script: packaging/install_torchdata.sh
32+
pre-script: ""
3333
post-script: ""
3434
conda-package-directory: packaging/torchtext
3535
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-wheels-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
matrix:
3535
include:
3636
- repository: pytorch/text
37-
pre-script: packaging/install_torchdata.sh
37+
pre-script: ""
3838
post-script: ""
3939
smoke-test-script: test/smoke_tests/smoke_tests.py
4040
package-name: torchtext

.github/workflows/build-wheels-m1.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
matrix:
3333
include:
3434
- repository: pytorch/text
35-
pre-script: packaging/install_torchdata.sh
35+
pre-script: ""
3636
post-script: ""
3737
package-name: torchtext
3838
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/build-wheels-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
matrix:
3434
include:
3535
- repository: pytorch/text
36-
pre-script: packaging/install_torchdata.sh
36+
pre-script: ""
3737
env-script: packaging/vc_env_helper.bat
3838
post-script: ""
3939
smoke-test-script: test/smoke_tests/smoke_tests.py

.github/workflows/codeql.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ jobs:
3131
- name: Install Torch
3232
run: |
3333
python -m pip install cmake
34-
python -m pip install --quiet --pre torch torchdata -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
3534
sudo ln -s /usr/bin/ninja /usr/bin/ninja-build
3635
3736
- name: Build TorchText

.github/workflows/integration-test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,13 @@ jobs:
3939
python -m spacy download en_core_web_sm
4040
printf "* Downloading SpaCy German models\n"
4141
python -m spacy download de_core_news_sm
42-
# Install PyTorch, Torchvision, and TorchData
42+
# Install PyTorch, Torchvision
4343
set -ex
4444
conda install \
4545
--yes \
4646
-c "pytorch-${CHANNEL}" \
4747
-c nvidia "pytorch-${CHANNEL}"::pytorch[build="*${VERSION}*"] \
4848
"${CUDATOOLKIT}"
49-
printf "Installing torchdata nightly\n"
50-
python3 -m pip install --pre torchdata --index-url https://download.pytorch.org/whl/nightly/cpu
5149
python3 setup.py develop
5250
# Install integration test dependencies
5351
python3 -m pip --quiet install parameterized

0 commit comments

Comments
 (0)