Skip to content

Update link to SacreMoses project repo to point to authoritative source, not a fork #2276

Open
@mbrukman

Description

📚 Documentation

Summary

This repo's README.md points to the https://github.com/alvations/sacremoses repo for the Sacramoses project:

Alternatively, you might want to use the `Moses <http://www.statmt.org/moses/>`_ tokenizer port in `SacreMoses <https://github.com/alvations/sacremoses>`_ (split from `NLTK <http://nltk.org/>`_). You have to install SacreMoses::

Similarly, in torchtext/data/utils.py:

"See the docs at https://github.com/alvations/sacremoses "

However, the authoritative home of this project appears to be https://github.com/hplt-project/sacremoses, so the repo links should be updated accordingly.

cc: @alvations (author of the above repo) to confirm or correct if this is a misunderstanding on my part (apologies in advance if that's the case).

Rationale and background research

https://github.com/alvations/sacremoses may have been correct repo at the time of initial extraction of Sacramoses from the NLTK project (see issue #306 and PR #361); however, today, https://github.com/alvations/sacremoses is a fork of https://github.com/hplt-project/sacremoses, and it appears that it is simply behind the other, authoritative project by a number of commits, without having any unique commits of its own:

This branch is 43 commits behind hplt-project/sacremoses:master.

We can also see that https://pypi.org/project/sacremoses/ has the "homepage" link pointing to https://github.com/hplt-project/sacremoses, further supporting that this is the authoritative source of the project.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions