Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment epoch should not reset num_steps_completed_in_epoch #864

Open
haarisr opened this issue Jul 15, 2024 · 0 comments
Open

Increment epoch should not reset num_steps_completed_in_epoch #864

haarisr opened this issue Jul 15, 2024 · 0 comments

Comments

@haarisr
Copy link

haarisr commented Jul 15, 2024

train_unit.train_progress.increment_epoch()
train_unit.on_train_epoch_end(state)
callback_handler.on_train_epoch_end(state, train_unit)

def increment_epoch(self) -> None:
"""Increment the epochs completed and resets the steps completed within the epoch."""
self._num_epochs_completed += 1
self._num_steps_completed_in_epoch = 0

If num_steps_completed_in_epoch is reset in increment_epoch, then the callback on_train_epoch_end cannot have access to the number of steps completed in the epoch.

@haarisr haarisr changed the title Increment epoch should not reset num_steps_competed_in_epoch Increment epoch should not reset num_steps_completed_in_epoch Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant