Skip to content

Commit 2ae42a0

Browse files
authored
Fix typos and add a missing break (#57)
Signed-off-by: Xiaodong Ye <[email protected]>
1 parent f31d3b1 commit 2ae42a0

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/lighthouse.rs

+1
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ fn quorum_valid(state: &RoomState, opt: &LighthouseOpt) -> (bool, String) {
106106
for prev_member in prev_quorum.participants.iter() {
107107
if !state.participants.contains_key(&prev_member.replica_id) {
108108
is_fast_quorum = false;
109+
break;
109110
}
110111
}
111112

torchft/manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def errored(self) -> Optional[Exception]:
274274
Get whether an error has occurred.
275275
276276
Returns:
277-
The error or None if no error has occured.
277+
The error or None if no error has occurred.
278278
"""
279279
return self._errored
280280

torchft/manager_test.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def test_quorum_heal_sync(self, client_mock: MagicMock) -> None:
132132
2, # max_world_size
133133
True, # heal
134134
)
135-
# forceable increment checkpoint server to compute correct address
135+
# forcible increment checkpoint server to compute correct address
136136
manager._ckpt_server.allow_checkpoint(manager.current_step())
137137

138138
client_mock().checkpoint_address.return_value = manager._ckpt_server.address()
@@ -174,7 +174,7 @@ def test_quorum_heal_async_not_enough_participants(
174174
1, # max_world_size
175175
True, # heal
176176
)
177-
# forceable increment checkpoint server to compute correct address
177+
# forcible increment checkpoint server to compute correct address
178178
manager._ckpt_server.allow_checkpoint(manager.current_step())
179179

180180
client_mock().checkpoint_address.return_value = manager._ckpt_server.address()

0 commit comments

Comments
 (0)