Skip to content

Commit

Permalink
Fix typos and add a missing break (#57)
Browse files Browse the repository at this point in the history
Signed-off-by: Xiaodong Ye <[email protected]>
  • Loading branch information
yeahdongcn authored Jan 7, 2025
1 parent f31d3b1 commit 2ae42a0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/lighthouse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ fn quorum_valid(state: &RoomState, opt: &LighthouseOpt) -> (bool, String) {
for prev_member in prev_quorum.participants.iter() {
if !state.participants.contains_key(&prev_member.replica_id) {
is_fast_quorum = false;
break;
}
}

Expand Down
2 changes: 1 addition & 1 deletion torchft/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def errored(self) -> Optional[Exception]:
Get whether an error has occurred.
Returns:
The error or None if no error has occured.
The error or None if no error has occurred.
"""
return self._errored

Expand Down
4 changes: 2 additions & 2 deletions torchft/manager_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def test_quorum_heal_sync(self, client_mock: MagicMock) -> None:
2, # max_world_size
True, # heal
)
# forceable increment checkpoint server to compute correct address
# forcible increment checkpoint server to compute correct address
manager._ckpt_server.allow_checkpoint(manager.current_step())

client_mock().checkpoint_address.return_value = manager._ckpt_server.address()
Expand Down Expand Up @@ -174,7 +174,7 @@ def test_quorum_heal_async_not_enough_participants(
1, # max_world_size
True, # heal
)
# forceable increment checkpoint server to compute correct address
# forcible increment checkpoint server to compute correct address
manager._ckpt_server.allow_checkpoint(manager.current_step())

client_mock().checkpoint_address.return_value = manager._ckpt_server.address()
Expand Down

0 comments on commit 2ae42a0

Please sign in to comment.