Skip to content

Commit 97ad397

Browse files
authored
lighthouse, manager: remove room support (#70)
1 parent e0f76e1 commit 97ad397

File tree

7 files changed

+101
-186
lines changed

7 files changed

+101
-186
lines changed

proto/torchft.proto

+4-12
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,7 @@ message Quorum {
5050
}
5151

5252
message LighthouseQuorumRequest {
53-
// room_id is the specific quorum channel to use. All workers/replicas
54-
// participating in the quorum must specify the same channel.
55-
// Multiple channels can be active simultaneously.
56-
string room_id = 1;
57-
QuorumMember requester = 2;
53+
QuorumMember requester = 1;
5854
}
5955

6056
message LighthouseQuorumResponse {
@@ -73,13 +69,9 @@ service LighthouseService {
7369
}
7470

7571
message ManagerQuorumRequest {
76-
// room_id is the specific quorum channel to use. All workers/replicas
77-
// participating in the quorum must specify the same channel.
78-
// Multiple channels can be active simultaneously.
79-
string room_id = 1;
80-
int64 rank = 2;
81-
int64 step = 3;
82-
string checkpoint_server_addr = 4;
72+
int64 rank = 1;
73+
int64 step = 2;
74+
string checkpoint_server_addr = 3;
8375
}
8476

8577
message ManagerQuorumResponse {

src/lib.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -105,19 +105,17 @@ impl ManagerClient {
105105
})
106106
}
107107

108-
#[pyo3(signature = (room_id, rank, step, checkpoint_server_addr, timeout=None))]
108+
#[pyo3(signature = (rank, step, checkpoint_server_addr, timeout=None))]
109109
fn quorum(
110110
&mut self,
111111
py: Python<'_>,
112-
room_id: String,
113112
rank: i64,
114113
step: i64,
115114
checkpoint_server_addr: String,
116115
timeout: Option<Duration>,
117116
) -> Result<(i64, i64, i64, String, String, i64, Option<i64>, i64, bool), StatusError> {
118117
py.allow_threads(move || {
119118
let mut request = tonic::Request::new(ManagerQuorumRequest {
120-
room_id: room_id,
121119
rank: rank,
122120
step: step,
123121
checkpoint_server_addr: checkpoint_server_addr,

0 commit comments

Comments
 (0)