Update

[ghstack-poisoned]

Author: fegin

torchft/process_group.py

@@ -816,7 +816,7 @@ def __init__(
         replicate_dim: int,
         parent: Optional["ManagedDeviceMesh"],
     ) -> None:
-        if mesh is None and parent is not None:
+        if mesh is None and parent is None:
             raise ValueError(
                 "ManagedDeviceMesh doesn't support both mesh and parent are None."
             )
@@ -876,7 +876,6 @@ def get_group(self, mesh_dim: Optional[Union[int, str]] = None) -> BaseProcessGr
             dim = 0 if mesh_dim is None else int(mesh_dim)
 
         if mesh_dim is None:
-            assert self.mesh is not None
             return self.replicate_pg
         elif dim == self.replicate_dim:
             return self.replicate_pg

torchft/process_group_test.py

@@ -316,6 +316,7 @@ def setUp(self) -> None:
         self._spawn_processes()
 
     def test_init_device_mesh(self) -> None:
+        os.environ["MASTER_ADDR"] = "127.0.0.1"
         os.environ["MASTER_PORT"] = str(12346)
         os.environ["RANK"] = str(self.rank)
         os.environ["WORLD_SIZE"] = str(4)