Skip to content

Commit 9cf9554

Browse files
author
Allen Chenjim Wang
committed
finalize
1 parent f6f89c3 commit 9cf9554

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

torchft/process_group_test.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -705,17 +705,16 @@ def tearDownClass(cls) -> None:
705705
def _create_pg(cls, backend: str) -> ProcessGroup:
706706
"""
707707
Helper that creates a new ProcessGroup of the specified type.
708-
We replicate the logic from the original test_* methods to decide how to
709-
instantiate Gloo, NCCL, or Baby versions, etc.
708+
709+
NCCL groups aren't currently supported - we prefer to test
710+
BabyNCCLGroups as they spin up their own subprocesses.
710711
"""
711712
if backend == "gloo":
712-
return ProcessGroupGloo(timeout=timedelta(seconds=2))
713-
elif backend == "nccl":
714-
return ProcessGroupNCCL()
713+
return ProcessGroupGloo(timeout=timedelta(seconds=1))
715714
elif backend == "baby_gloo":
716715
return ProcessGroupBabyGloo(timeout=timedelta(seconds=2))
717716
elif backend == "baby_nccl":
718-
return ProcessGroupBabyNCCL(timeout=timedelta(seconds=5))
717+
return ProcessGroupBabyNCCL(timeout=timedelta(seconds=10))
719718
else:
720719
# fallback / dummy
721720
return ProcessGroupDummy(0, 1)

0 commit comments

Comments
 (0)