Skip to content

ManagerClient.quorum should return a namedtuple, dataclass or object #52

Open
@Jackmin801

Description

class ManagerClient:
    def quorum(
        self, room_id: str, rank: int, step: int, checkpoint_server_addr: str
    ) -> Tuple[int, int, int, str, str, int, Optional[int], int, bool]: ...
            Ok((
                resp.quorum_id,
                resp.replica_rank,
                resp.replica_world_size,
                resp.address,
                resp.store_address,
                resp.max_step,
                resp.max_rank,
                resp.max_world_size,
                resp.heal,
            ))

This can be quite hard to read from the python side. Might be nice to wrap it in an object of sorts so the elements can be referred to by attribute name.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions