Commit 25c9530
authored
[spmd_types] fix dsv3 ep + chunk loss typecheck (#3866)
https://github.com/pytorch/torchtitan/actions/runs/28794699622/job/85382003819
- ChunkedLossWrapper(CrossEntropyLoss) wrapper refactor broke typecheck,
since now it always goes through base loss class
- existing bug for EP + no typecheck1 parent d04f7b9 commit 25c9530
2 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
327 | 327 | | |
328 | 328 | | |
329 | 329 | | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
330 | 334 | | |
331 | 335 | | |
332 | 336 | | |
| |||
354 | 358 | | |
355 | 359 | | |
356 | 360 | | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
357 | 365 | | |
358 | 366 | | |
359 | 367 | | |
| |||
737 | 745 | | |
738 | 746 | | |
739 | 747 | | |
740 | | - | |
741 | | - | |
742 | | - | |
743 | 748 | | |
744 | 749 | | |
745 | 750 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
448 | 448 | | |
449 | 449 | | |
450 | 450 | | |
451 | | - | |
| 451 | + | |
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| |||
0 commit comments