Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop_last does not work with ConcatDataset #1754

Open
RdoubleA opened this issue Oct 5, 2024 · 0 comments
Open

drop_last does not work with ConcatDataset #1754

RdoubleA opened this issue Oct 5, 2024 · 0 comments
Assignees
@felipemello1

Comments

@RdoubleA
Copy link
Contributor

RdoubleA commented Oct 5, 2024 •
edited
Loading

drop_last is expected to be specified with the dataset config object, but this errors out when you use multiple datasets and cfg_dataset becomes a ListConfig: https://github.com/pytorch/torchtune/blob/main/recipes/full_finetune_distributed.py#L511

Possible fixes:

  • Always use drop_last=True
  • Explicitly check for ListConfig, if so just use True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipemello1 felipemello1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felipemello1 @RdoubleA