Skip to content

[Clean up] Move evaluation configs under model directories  #1810

Open
@joecummings

Description

Currently, evaluation.yaml exists under the configs/ directory. To start, we wanted to just showcase this recipes as an example, but it is a core part of the finetuning process and therefore should mirror the pattern we've established for other configs in which they reside under model-specific directories.

The change for each model directory will consist of four steps:

  1. Copy evaluation.yaml under whichever model you are focused upon.
  2. Update the defaults from llama2 to the current model defaults.
  3. Update the _recipe_registry.py to make sure the new YAML file can be found with the following command: tune run eleuther_eval --config MODEL/evaluation
  4. Put up a PR with output from running the evaluation script. Here's an example for Qwen2: Add evaluation configs under qwen2 dir #1809

If there are multiple sizes of model that exist in the directory, select the most commonly used one. This is certainly up for interpretation, but typically ~7B params is standard. We want to give a good example, but there's no need to proliferate configs for every model SIZE.

Checklist:

After all of these are completed, we will deprecate the evaluation.yaml configs in the base configs directory.

Thanks, everyone, for your help! 🎉

Metadata

Assignees

No one assigned

    Labels

    best practiceThings we should be doing but aren'tcommunity help wantedWe would love the community's help completing this issuegood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions