(torchx/local_scheduler) Use os.kill instead of os.killpg when sending SIGTERM to the replica pid. Add runner.wait() for torchx.runner.test.api_test#test_empty_session_id to gracefully wait for the replicas to finish running

Differential Revision: D74197282

Pull Request resolved: #1062

Author: kiukchung

torchx/runner/test/api_test.py

@@ -153,6 +153,7 @@ def test_empty_session_id(self, _: MagicMock) -> None:
             )
 
             app_handle = runner.run(app, "local", self.cfg)
+            runner.wait(app_handle, wait_interval=0.1)
 
             scheduler, session_name, app_id = parse_app_handle(app_handle)
             self.assertEqual(scheduler, "local")

torchx/schedulers/local_scheduler.py

@@ -311,7 +311,7 @@ def terminate(self) -> None:
         """
         # safe to call terminate on a process that already died
         try:
-            os.killpg(self.proc.pid, signal.SIGTERM)
+            os.kill(self.proc.pid, signal.SIGTERM)
         except ProcessLookupError as e:
             log.debug(f"Process {self.proc.pid} already got terminated")