Skip to content

Commit 907e855

Browse files
authored
Cleaup Component Help for TorchX and add message for xlformers
Differential Revision: D55401844 Pull Request resolved: #860
1 parent 6791a8e commit 907e855

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

torchx/specs/file_linter.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ def _get_default_arguments_descriptions(fn: Callable[..., object]) -> Dict[str,
3131
return args_decs
3232

3333

34-
class TorchXArgumentHelpFormatter(argparse.HelpFormatter):
34+
class TorchXArgumentHelpFormatter(
35+
argparse.RawDescriptionHelpFormatter,
36+
argparse.ArgumentDefaultsHelpFormatter,
37+
argparse.MetavarTypeHelpFormatter,
38+
):
3539
"""Help message formatter which adds default values and required to argument help.
3640
3741
If the argument is required, the class appends `(required)` at the end of the help message.
@@ -81,7 +85,7 @@ def get_fn_docstring(fn: Callable[..., object]) -> Tuple[str, Dict[str, str]]:
8185
args_description[param.arg_name] = param.description
8286
short_func_description = docstring.short_description or default_fn_desc
8387
if docstring.long_description:
84-
short_func_description += " ..."
88+
short_func_description += "\n" + docstring.long_description
8589
return (short_func_description or default_fn_desc, args_description)
8690

8791

torchx/specs/test/file_linter_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def test_validate_args_no_type_defs_complex(self) -> None:
193193

194194
def test_validate_docstring(self) -> None:
195195
func_desc, param_desc = get_fn_docstring(_test_docstring)
196-
self.assertEqual("Short Test description ...", func_desc)
196+
self.assertEqual("Short Test description\nLong funct description", func_desc)
197197
self.assertEqual("arg0 desc", param_desc["arg0"])
198198
self.assertEqual("arg1 desc", param_desc["arg1"])
199199
self.assertEqual(" ", param_desc["arg2"])

0 commit comments

Comments
 (0)