Open
Description
Original context: #4240
Dfeault installation of torchvision and ffmpeg without version installs a non-workable ffmpeg 4.3 missing some libraries and gets installed for some reason from PyTorch channel.
I also read in other threads https://github.com/pytorch/vision/issues?q=is%3Aissue+is%3Aopen+ffmpeg that torchvision currently needs ffmpeg 4.2, but this is not reflected in dependency versions.
Also, building torchvision with ffmpeg from source is source of a lot of problems (in the issue search above)
Could README / torchvision:
- recommend a known workable installation command of ffmpeg (maybe version-pinned? or with fixed dependency versions?)
- recommend a known workable installation command of ffmpeg that lets you build torchvision from sources
At best it would be great to have a simple CI test installing from conda pytorch / torchvision / ffmpeg / opencv / maybe pillow-simd / open3d and a simple CI test for building from sources (as a regular user would).
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
bjuncek commentedon Aug 9, 2021
Hi @vadimkantorov
There are some issues regarding packaging FFMPEG directly with tochvision; last I recall it was licensing, but I'm trying to gather the info from people that have been working on it for the past years (specifically @andfoy and @fmassa ) and put all the information in the same issue. @vmoens proposed a solution in #4218 but that needs to be tested on different platforms.
fmassa commentedon Aug 9, 2021
Hi Vadim,
Here is some clarification about the ffmpeg that gets pulled from the PyTorch channel:
It might be that in the meantime some dependencies got messed up with latest releases (which makes our ffmpeg package not workable anymore). We should revisit what we are doing and come up with a more robust solution
vadimkantorov commentedon Aug 10, 2021
This should be clearly warned somehow, it's very non-obvious that PyTorch channels ships its own ffmpeg and that it takes precedence over regular ffmpeg package. Also, the shipped version's executable seems broken and misses some libraries. Maybe also ffmpeg could be compiled with torchvision banner so that it's clear that it torchvision's version + it may contain URL to docs. Users may also want to have a regular GPL ffmpeg installed side by side, so somehow there should be a recipe of having both simultaneously or this should be clearly discussed in the docs.
It still installed 4.3, while that issue says that it's 4.3 has the bug
Maybe you should not always ship it (for binary size?) or having an option of using dynamically loaded users-installed ffmpeg?
fmassa commentedon Aug 13, 2021
@vadimkantorov yes, we definitely need to improve the situation here. Many of us were on holidays the past month (so things have been a bit slow), but we will be investigating and fixing it soon.
vadimkantorov commentedon Oct 19, 2021
Given bugginess / unscrutinability of conda regarding conflicts, it would also be nice to have automated regular testing of installation recipes for conda, also including opencv which is also a frequent companion of torchvision. Some CI testing of installation commands was implemented within the scope of pytorch/pytorch#62590 cc @malfet
[-]Recommend a working conda installation command of ffmpeg[/-][+]Recommend a working conda installation sequence of torchvision, ffmpeg, opencv (both python and shared libraries + includes) together[/+]vadimkantorov commentedon Mar 18, 2022
Another instance is: #5616
It would be nice to have a nightly test of conda/pip installs of torchvision + opencv + ffmpeg -> this is a very common scenario, and even if it doesn't work, it'd be nice to have a "badge" indicating working or not working install. At the very least, there needs to exist known/tested conda+pip recipes of installation of these libraries...
vadimkantorov commentedon Mar 22, 2022
Another idea: add open3d and have a fuzzer about import order: pytorch/pytorch#74547. All these issues about which blas gets loaded and which OpenMP variant gets loaded...
malfet commentedon Mar 23, 2022
cc: @janeyx99
10 remaining items