Skip to content

Align query_chw and get_dimensions #7809

Open
@pmeier

Description

@pmeier

We have to proper combination

def get_size(inpt: datapoints._InputTypeJIT) -> List[int]:

def query_size(flat_inputs: List[Any]) -> Tuple[int, int]:

However, we have the combination below that diverges on the name

def get_dimensions(inpt: Union[datapoints._ImageTypeJIT, datapoints._VideoTypeJIT]) -> List[int]:

def query_chw(flat_inputs: List[Any]) -> Tuple[int, int, int]:

I don't recall anymore how we ended up with this, but we should correct it.

My vote is out for also calling it query_dimensions since we already have

def get_dimensions(img: Tensor) -> List[int]:

in v1.

cc @vfdev-5

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions