Merge pull request #309 from unsnow-iac/fix/climate-settings-500

Gracefully handle climate-settings HTTP 500 (fixes #294)

Author: deejay1

custom_components/toyota/__init__.py

@@ -593,11 +593,21 @@ async def _refresh_one_vehicle(vehicle: Vehicle) -> VehicleData:
         # Bounded so a slow/flaky non-status endpoint can't stall first_refresh
         # past HA's setup budget. On timeout the TimeoutError propagates to the
         # caller's per-vehicle handler, which serves cache or a stub - same
-        # degrade path as any other transient Toyota failure.
-        await asyncio.wait_for(
-            _call_tagged("vehicle.update", vin, vehicle.update(skip=["status"])),
-            STATUS_FETCH_BUDGET_S,
-        )
+        # degrade path as any other transient Toyota failure. A climate-settings
+        # (or other endpoint) HTTP 500 surfaces here as a ToyotaApiError/
+        # ToyotaInternalError - swallow it so a single bad endpoint doesn't fail
+        # the whole refresh; the rest of the snapshot still builds from cache.
+        try:
+            await asyncio.wait_for(
+                _call_tagged("vehicle.update", vin, vehicle.update(skip=["status"])),
+                STATUS_FETCH_BUDGET_S,
+            )
+        except (ToyotaApiError, ToyotaInternalError) as ex:
+            _LOGGER.warning(
+                "vehicle.update partial failure for vin=...%s (%s), continuing",
+                (vin or "")[-6:],
+                _error_code(ex),
+            )
 
         # Build snapshot for the strategy.
         current_odometer_km: float | None = None

custom_components/toyota/climate.py

@@ -123,7 +123,7 @@ def __init__(
     def _load_climate_settings_from_coordinator(self) -> None:
         """Load climate settings from coordinator data if available."""
         try:
-            if not self.vehicle or not hasattr(self.vehicle, "climate_settings"):
+            if not self.vehicle or not getattr(self.vehicle, "climate_settings", None):
                 _LOGGER.debug("Vehicle climate_settings not yet available")
                 return
 
@@ -147,18 +147,24 @@ def _load_temperature_settings(self) -> None:
         """Load temperature settings from climate_settings."""
         climate_settings = self.vehicle.climate_settings
         target_temperature = climate_settings.temperature
-        if target_temperature is not None:
+        if target_temperature is not None and target_temperature.value is not None:
             self._attr_target_temperature = target_temperature.value
-        self._attr_min_temp = getattr(climate_settings, "min_temp", 18)
-        self._attr_max_temp = getattr(climate_settings, "max_temp", 29)
-        self._attr_target_temperature_step = getattr(
-            climate_settings, "temp_interval", 1
+        # `or <default>` guards against the attribute existing but being None
+        # (climate-settings HTTP 500). A None min/max_temp makes HA core's
+        # set_temperature validation do `float < None` -> TypeError; keep the
+        # __init__ defaults (18/29/1) instead.
+        self._attr_min_temp = getattr(climate_settings, "min_temp", None) or 18
+        self._attr_max_temp = getattr(climate_settings, "max_temp", None) or 29
+        self._attr_target_temperature_step = (
+            getattr(climate_settings, "temp_interval", None) or 1
         )
 
     def _load_defrost_settings(self) -> None:
         """Load defrost settings from climate_settings operations."""
         climate_settings = self.vehicle.climate_settings
-        operations = getattr(climate_settings, "operations", [])
+        # API can return operations=None (e.g. climate-settings HTTP 500);
+        # `or []` guards against the attribute existing but being None.
+        operations = getattr(climate_settings, "operations", None) or []
         for operation in filter(lambda o: o.category_name == "defrost", operations):
             for param in operation.parameters:
                 if param.name == "frontDefrost":
@@ -224,8 +230,11 @@ def _create_climate_settings(self) -> ClimateSettingsModel:
         Returns:
             ClimateSettingsModel configured with the specified settings
         """
-        # Start with existing operations
-        ac_operations = self.vehicle.climate_settings.operations.copy()
+        # Start with existing operations. climate_settings itself (not just
+        # .operations) can be None when the climate-settings endpoint 500'd, so
+        # getattr through both to avoid an AttributeError on the control path.
+        climate_settings = getattr(self.vehicle, "climate_settings", None)
+        ac_operations = (getattr(climate_settings, "operations", None) or []).copy()
 
         # Find and replace the defrost operation
         for i, operation in enumerate(ac_operations):