Skip to content

Commit 5abe1fa

Browse files
authored
docs(pyvista): #117 is a by-design int32-default compression-ratio artifact (#141)
1 parent 710c07d commit 5abe1fa

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

tests/pyvista/deselect.txt

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
# --- REAL fvtk divergences from stock 9.6.2 (tracked; remove when fixed) -----
2020
# These FAIL on fvtk but PASS on stock 9.6.2 on the same machine. Tracking
2121
# issues filed on pyvista/fvtk; fix each, then delete its line here.
22-
tests/core/test_dataobject.py::test_save_compression # XML writer compression weaker than stock (#117)
2322
tests/core/test_helpers.py::test_to_from_trimesh_points_faces # regular_faces not zero-copy (#118)
2423
tests/plotting/test_plotting.py::test_export_gltf # glTF export render divergence, same-Mesa (#119)
2524

@@ -33,6 +32,17 @@ tests/core/test_dataobject_filters.py::test_cell_status
3332
# so the committed image_cache was generated against a different VTK/Mesa.
3433
tests/plotting/test_plotting.py::test_set_environment_texture_cubemap[True]
3534

35+
# --- by-design consequence of fvtk int32-default storage (won't fix) --------
36+
# fvtk defaults topology/connectivity arrays to int32 (stock uses int64). The
37+
# test asserts compressed_size < uncompressed_size / 4. fvtk's compressed output
38+
# is actually SMALLER than stock's (e.g. sphere: 21595 vs 22671 bytes), but its
39+
# UNCOMPRESSED baseline is far smaller too (65199 vs 101039) because int32 halves
40+
# the connectivity/offset arrays and stock's int64 arrays are full of zero
41+
# high-bytes that compress almost for free. So fvtk's *ratio* is ~3x vs stock's
42+
# ~4.5x even though the absolute file is smaller. The 4x threshold assumes int64
43+
# padding; there is no fix that keeps the int32 storage win. See #117.
44+
tests/core/test_dataobject.py::test_save_compression # int32-default lowers compression RATIO (smaller file); by design (#117)
45+
3646
# --- intentional fvtk build exclusion (won't fix) ---------------------------
3747
# fvtk's module closure excludes IOXdmf2: the vendored ThirdParty/xdmf2 fails to
3848
# compile on modern libc++ (<strstream> removed) and only backs XdmfReader.

0 commit comments

Comments
 (0)