+ internal PendingTaskCountingThrottleExecutor method change

Author: q3769

pom.xml

@@ -30,7 +30,7 @@
 
     <groupId>io.github.q3769</groupId>
     <artifactId>conottle</artifactId>
-    <version>11.0.4</version>
+    <version>11.0.5</version>
     <packaging>jar</packaging>
     <name>conottle</name>
     <description>A Java concurrent API to throttle the maximum concurrency to process tasks for any given client while

src/main/java/conottle/Conottle.java

@@ -86,11 +86,11 @@ public <V> CompletableFuture<V> submit(@NonNull Callable<V> task, @NonNull Objec
         CompletableFuture<V> copy = taskCompletableFuture.thenApply(r -> r);
         taskCompletableFuture.whenCompleteAsync((r, e) -> activeThrottlingExecutors.computeIfPresent(clientId,
                 (k, checkedExecutor) -> {
-                    if (checkedExecutor.noPendingWorkAfterTaskComplete()) {
-                        returnToPool(checkedExecutor);
-                        return null;
+                    if (checkedExecutor.moreWorkPendingAfterTaskComplete()) {
+                        return checkedExecutor;
                     }
-                    return checkedExecutor;
+                    returnToPool(checkedExecutor);
+                    return null;
                 }), adminExecutorService);
         return copy;
     }

src/main/java/conottle/PendingTaskCountingThrottleExecutor.java

@@ -64,11 +64,11 @@ final class PendingTaskCountingThrottleExecutor implements PendingWorkAwareExecu
      *         completed task
      */
     @Override
-    public boolean noPendingWorkAfterTaskComplete() {
+    public boolean moreWorkPendingAfterTaskComplete() {
         if (pendingTaskCount <= 0) {
             throw new IllegalStateException("Cannot further decrement from pending task count: " + pendingTaskCount);
         }
-        return --pendingTaskCount == 0;
+        return --pendingTaskCount != 0;
     }
 
     @Override

src/main/java/conottle/PendingWorkAwareExecutor.java

@@ -36,10 +36,10 @@ interface PendingWorkAwareExecutor {
     /**
      * Intended to be called after each task is completed by this service.
      *
-     * @return true if this executor has no more pending tasks after the task whose completion triggered this method
+     * @return true if this executor has more pending tasks after the task whose completion triggered this method
      *         invocation
      */
-    boolean noPendingWorkAfterTaskComplete();
+    boolean moreWorkPendingAfterTaskComplete();
 
     @NonNull <V> CompletableFuture<V> submit(Callable<V> task);