Skip to content

Commit 651e0c4

Browse files
committed
simplifying log lib in tests
1 parent a75c963 commit 651e0c4

File tree

2 files changed

+8
-20
lines changed

2 files changed

+8
-20
lines changed

pom.xml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
<groupId>io.github.q3769</groupId>
3232
<artifactId>semver-maven-plugin</artifactId>
33-
<version>20240116.0.202507152211</version>
33+
<version>20240116.0.202507281844</version>
3434
<packaging>maven-plugin</packaging>
3535

3636
<name>semver-maven-plugin</name>
@@ -125,18 +125,6 @@
125125
<artifactId>commons-lang3</artifactId>
126126
<version>3.18.0</version>
127127
</dependency>
128-
<dependency>
129-
<groupId>io.github.elf4j</groupId>
130-
<artifactId>elf4j-provider</artifactId>
131-
<version>15.1.0</version>
132-
<scope>test</scope>
133-
</dependency>
134-
<dependency>
135-
<groupId>org.slf4j</groupId>
136-
<artifactId>slf4j-api</artifactId>
137-
<version>2.0.17</version>
138-
<scope>test</scope>
139-
</dependency>
140128
<dependency>
141129
<groupId>org.junit.jupiter</groupId>
142130
<artifactId>junit-jupiter</artifactId>
@@ -257,7 +245,7 @@
257245
<plugin>
258246
<groupId>io.github.q3769</groupId>
259247
<artifactId>semver-maven-plugin</artifactId>
260-
<version>20240116.0.202507152211</version>
248+
<version>20240116.0.202507281844</version>
261249
</plugin>
262250
<plugin>
263251
<groupId>org.apache.maven.plugins</groupId>

src/test/java/q3769/maven/plugins/semver/mojos/MergeTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@
2929
import static q3769.maven.plugins.semver.NormalVersion.MINOR;
3030

3131
import com.github.zafarkhaja.semver.Version;
32-
import elf4j.Logger;
32+
import java.util.logging.Logger;
3333
import org.apache.maven.plugin.MojoFailureException;
3434
import org.junit.jupiter.api.Nested;
3535
import org.junit.jupiter.api.Test;
3636
import q3769.maven.plugins.semver.NormalVersion;
3737

3838
class MergeTest {
39-
static final Logger info = Logger.instance().atInfo();
39+
static final Logger log = Logger.getLogger(MergeTest.class.getName());
4040

4141
Merge mergeMojo = new Merge();
4242

@@ -46,12 +46,12 @@ class update {
4646
void whenOriginalVersionIsNewer() throws MojoFailureException {
4747
Version original = Version.parse("1.4.0-SNAPSHOT");
4848
Version toMerge = Version.parse("1.3.4-hotfix");
49-
info.log("Merging " + toMerge + " to " + original);
49+
log.info(String.format("Merging %s to %s", toMerge, original));
5050
assertTrue(original.compareTo(toMerge) > 0);
5151
mergeMojo.otherSemVer = toMerge.toString();
5252

5353
Version updated = mergeMojo.update(original);
54-
info.log("Merge result: " + updated);
54+
log.info(String.format("Merge result: %s", updated));
5555

5656
assertEquals(original, updated);
5757
}
@@ -60,13 +60,13 @@ void whenOriginalVersionIsNewer() throws MojoFailureException {
6060
void whenOriginalVersionIsOlder() throws MojoFailureException {
6161
Version original = Version.parse("1.2.0-pre-release.1+build.metadata");
6262
Version toMerge = Version.parse("1.3.4-hotfix");
63-
info.log("Merging " + toMerge + " to " + original);
63+
log.info(String.format("Merging %s to %s", toMerge, original));
6464
mergeMojo.otherSemVer = toMerge.toString();
6565
assertTrue(original.compareTo(toMerge) < 0);
6666
assertEquals(MINOR, NormalVersion.getLastIncrementedNormalVersion(original));
6767

6868
Version updated = mergeMojo.update(original);
69-
info.log("Merge result: " + updated);
69+
log.info(String.format("Merge result: %s", updated));
7070

7171
assertEquals(Version.parse("1.4.0-pre-release.1+build.metadata"), updated);
7272
}

0 commit comments

Comments
 (0)