Merge pull request #9 from qa-dev/QA-5665_return_to_available

podtserkovskiy · web-flow · commit c78ec8e8b224 · 2017-09-14T17:00:37.000+03:00
QA-5665: return status to available on failure session creation
diff --git a/handlers/createSession.go b/handlers/createSession.go
@@ -90,6 +90,10 @@ func (h *CreateSession) tryCreateSession(r *http.Request, capabilities *capabili
 	reverseProxy.ServeHTTP(tw, r)
 
 	if !transport.IsSuccess {
+		err = h.Pool.CleanUpNode(node)
+		if err != nil {
+			log.Errorf("fail cleanUp node on create session failure, %s", err)
+		}
 		return nil, errors.New("Failure proxy request on node " + node.String() + ": " + string(tw.Output))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,10 @@ func (h CreateSession) tryCreateSession(r http.Request, capabilities *capabili`
`90`	`90`	`reverseProxy.ServeHTTP(tw, r)`
`91`	`91`
`92`	`92`	`if !transport.IsSuccess {`
	`93`	`+ err = h.Pool.CleanUpNode(node)`
	`94`	`+ if err != nil {`
	`95`	`+ log.Errorf("fail cleanUp node on create session failure, %s", err)`
	`96`	`+ }`
`93`	`97`	`return nil, errors.New("Failure proxy request on node " + node.String() + ": " + string(tw.Output))`
`94`	`98`	`}`
`95`	`99`