Core

Author: qarmin

.github/ISSUE_TEMPLATE/bug_report.md

@@ -31,10 +31,10 @@ Very helpful in this situation will be logs from czkawka run with RUST_LOG envir
 ```
 
 **System**
-<!-- OS and Czkawka/Krokiet version, you can just copy from logs, if you run app from terminal. -->
+<!-- OS and Czkawka/Krokiet version, you can just copy from logs, if you run app from terminal or find it in logs file. -->
 <!-- Example of logs: -->
 <!-- Czkawka gtk version: 9.0.0, debug mode, rust 1.85.0 (2025-02-17), os Ubuntu 24.10.0 [x86_64 64-bit], 24 cpu/threads, features(1): [fast_image_resize], app cpu version: [x86-64-v3 (AVX2) or x86-64-v4 (AVX-512)], os cpu version: [x86-64-v4 (AVX-512)] !-->
-
+<!-- Please do not report feature request for Gtk Czkawka gui, because it is in maintenance mode. -->
 
 - Czkawka/Krokiet version: <!--  e.g. 9.0.0 cli/gui -->
 - OS version: <!--  e.g Ubuntu 22.04, Windows 11, Mac 15.1 ARM -->

czkawka_core/i18n/en/czkawka_core.ftl

@@ -27,7 +27,6 @@ core_directory_unable_to_get_device_id = Directories: Unable to get device id fr
 
 core_ffmpeg_not_found = Cannot find proper installation of FFmpeg
 core_ffmpeg_not_found_windows = Be sure that ffmpeg.exe and ffprobe.exe are available in PATH or are put directly to same folder where is app executable
-core_ffmpeg_missing_in_snap = Similar Videos don't work currently with snap, if you want help look at - { $url }
 
 core_saving_to_cache = Saved to file { $number } cache entries
 core_loading_from_cache = Loaded from cache { $number } entries

czkawka_core/src/common.rs

@@ -503,6 +503,7 @@ pub fn create_crash_message(library_name: &str, file_path: &str, home_library_ur
     )
 }
 
+#[allow(clippy::string_slice)]
 pub fn regex_check(expression_item: &SingleExcludedItem, directory_name: &str) -> bool {
     if expression_item.expression_splits.is_empty() {
         return true;
@@ -546,6 +547,7 @@ pub fn regex_check(expression_item: &SingleExcludedItem, directory_name: &str) -
     true
 }
 
+#[allow(clippy::string_slice)] // Is in char boundary
 pub fn normalize_windows_path(path_to_change: impl AsRef<Path>) -> PathBuf {
     let path = path_to_change.as_ref();
 

czkawka_core/src/common_cache.rs

@@ -18,13 +18,13 @@ use crate::common_traits::ResultEntry;
 use crate::tools::duplicate::HashType;
 use crate::tools::similar_images::{convert_algorithm_to_string, convert_filters_to_string};
 
-const CACHE_VERSION: &str = "70";
-const CACHE_DUPLICATE_VERSION: &str = "90";
+const CACHE_VERSION: &str = "100";
+const CACHE_DUPLICATE_VERSION: &str = "100";
 #[cfg(feature = "fast_image_resize")]
-const CACHE_IMAGE_VERSION: &str = "90_fast_resize";
+const CACHE_IMAGE_VERSION: &str = "100_fast_resize";
 #[cfg(not(feature = "fast_image_resize"))]
-const CACHE_IMAGE_VERSION: &str = "90_image_rs_resize";
-const CACHE_VIDEO_VERSION: &str = "90";
+const CACHE_IMAGE_VERSION: &str = "100_image_rs_resize";
+const CACHE_VIDEO_VERSION: &str = "100";
 
 const MEMORY_LIMIT: u64 = 4 * 1024 * 1024 * 1024;
 

czkawka_core/src/common_extensions.rs

@@ -67,6 +67,7 @@ impl Extensions {
         messages
     }
 
+    #[allow(clippy::string_slice)] // Valid, because we address go to dot, which is known ascii character
     pub fn check_if_entry_have_valid_extension(&self, entry_data: &DirEntry) -> bool {
         if self.allowed_extensions_hashset.is_empty() && self.excluded_extensions_hashset.is_empty() {
             return true;

czkawka_core/src/lib.rs

@@ -6,6 +6,7 @@
 #![warn(clippy::print_stderr)]
 #![warn(clippy::print_stdout)]
 #![warn(clippy::dbg_macro)]
+#![warn(clippy::string_slice)]
 
 #[macro_use]
 extern crate bitflags;

czkawka_core/src/tools/broken_files.rs

@@ -452,6 +452,7 @@ impl PrintResults for BrokenFiles {
     }
 }
 
+#[allow(clippy::string_slice)] // Valid, because we address go to dot, which is known ascii character
 fn check_extension_availability(
     full_name: &Path,
     images_extensions: &HashSet<&&'static str>,
@@ -500,6 +501,7 @@ fn unpack_pdf_error(e: PdfError) -> PdfError {
     }
 }
 
+#[allow(clippy::string_slice)] // Safe slicing
 fn validate_pdf_error(file_entry: &mut BrokenEntry, e: PdfError) -> PdfError {
     let mut error_string = e.to_string();
     // Workaround for strange error message https://github.com/qarmin/czkawka/issues/898

czkawka_core/src/tools/similar_videos.rs

@@ -120,11 +120,6 @@ impl SimilarVideos {
             self.common_data.text_messages.errors.push(flc!("core_ffmpeg_not_found"));
             #[cfg(target_os = "windows")]
             self.common_data.text_messages.errors.push(flc!("core_ffmpeg_not_found_windows"));
-            #[cfg(target_os = "linux")]
-            self.common_data
-                .text_messages
-                .errors
-                .push(flc!("core_ffmpeg_missing_in_snap", url = "https://github.com/snapcrafters/ffmpeg/issues/73"));
         } else {
             self.prepare_items();
             self.common_data.use_reference_folders = !self.common_data.directories.reference_directories.is_empty();

czkawka_gui/README.md

@@ -4,6 +4,12 @@ Czkawka GUI is a graphical user interface for Czkawka Core written with GTK 4.
 
 ![Screenshot from 2023-11-26 12-43-32](https://github.com/qarmin/czkawka/assets/41945903/722ed490-0be1-4dac-bcfc-182a4d0787dc)
 
+## Maintenance mode
+
+Czkawka Gtk is currently in maintenance mode.  
+While no new features will be added (at least by me), bug fixes and compatibility updates with the Czkawka core package will continue to be provided.  
+Active development is now focused on the Krokiet GUI.
+
 ## Requirements
 
 Requirements depend on your platform.
@@ -18,11 +24,6 @@ Additional features like heif, libraw, libavif require additional libraries to b
 
 Ubuntu - `sudo apt install libgtk-4-bin libheif1 libraw-bin ffmpeg -y`
 
-#### Snap -
-
-none - all needed libraries are bundled in
-snap [except ffmpeg](https://github.com/snapcrafters/ffmpeg/issues/73)  - https://snapcraft.io/czkawka
-
 #### Flatpak
 
 none - all needed libraries are bundled - https://flathub.org/apps/com.github.qarmin.czkawka