test: cover scoped recalc error paths

Author: krystophny

recalc_test.go

@@ -185,6 +185,21 @@ func TestRecalcWorkbookWithoutFormulas(t *testing.T) {
 	assert.NoError(t, f.Recalc())
 }
 
+func TestRecalcRejectsChartSheet(t *testing.T) {
+	f := NewFile()
+	assert.NoError(t, f.SetCellInt("Sheet1", "A1", 1))
+	assert.NoError(t, f.SetCellInt("Sheet1", "A2", 2))
+	assert.NoError(t, f.AddChartSheet("Chart1", &Chart{
+		Type: Col,
+		Series: []ChartSeries{{
+			Categories: "Sheet1!$A$1:$A$2",
+			Values:     "Sheet1!$A$1:$A$2",
+		}},
+	}))
+
+	assert.Error(t, f.Recalc(RecalcOptions{Sheet: "Chart1"}))
+}
+
 func TestRecalcAggregatesFailures(t *testing.T) {
 	// An unsupported function on one cell must not prevent other cells
 	// from being recalculated. The returned error is the join of
@@ -240,7 +255,7 @@ func TestRecalcRefScope(t *testing.T) {
 	assert.NoError(t, f.Recalc(RecalcOptions{Sheet: "Sheet1", Ref: "A1:A10"}))
 
 	assert.Equal(t, "2", cellXML(t, f, "Sheet1", "A2").V)
-	assert.Empty(t, cellXML(t, f, "Sheet1", "B2").V, "B2 out of scope")
+	assert.Empty(t, cellXML(t, f, "Sheet1", "B2").V, "B2 cache remains empty")
 }
 
 func TestRecalcOptionRejects(t *testing.T) {
@@ -249,3 +264,53 @@ func TestRecalcOptionRejects(t *testing.T) {
 	assert.ErrorContains(t, f.Recalc(RecalcOptions{Sheet: "Nope"}), `"Nope"`)
 	assert.ErrorContains(t, f.Recalc(RecalcOptions{Sheet: "Sheet1", Ref: "not-a-range"}), "invalid Ref")
 }
+
+func TestCollectRecalcCellsSkipsMalformedCellReference(t *testing.T) {
+	f := NewFile()
+	assert.NoError(t, f.SetCellFormula("Sheet1", "A1", "1+1"))
+	assert.NoError(t, f.SetCellFormula("Sheet1", "B1", "2+2"))
+	ws, err := f.workSheetReader("Sheet1")
+	assert.NoError(t, err)
+	ws.SheetData.Row[0].C[0].R = "bad-ref"
+
+	cells, err := f.collectRecalcCells(RecalcOptions{Sheet: "Sheet1"})
+	assert.NoError(t, err)
+	assert.Equal(t, []recalcTarget{{sheet: "Sheet1", cell: "B1"}}, cells)
+}
+
+func TestSetCellCachedValueRejectsBadTarget(t *testing.T) {
+	f := NewFile()
+
+	assert.Error(t, f.setCellCachedValue("Nope", "A1", newNumberFormulaArg(1)))
+	assert.Error(t, f.setCellCachedValue("Sheet1", "bad-ref", newNumberFormulaArg(1)))
+}
+
+func TestSetCachedArgTypes(t *testing.T) {
+	cases := []struct {
+		name  string
+		arg   formulaArg
+		wantT string
+		wantV string
+	}{
+		{"string", newStringFormulaArg("ready"), "str", "ready"},
+		{"formula_error", newErrorFormulaArg(formulaErrorVALUE, formulaErrorVALUE), "e", formulaErrorVALUE},
+		{"empty", newEmptyFormulaArg(), "", ""},
+		{"unknown", formulaArg{Type: ArgUnknown}, "", ""},
+		{"matrix_scalar_head", newMatrixFormulaArg([][]formulaArg{{newStringFormulaArg("top")}}), "str", "top"},
+		{"matrix_nested_head", newMatrixFormulaArg([][]formulaArg{{newMatrixFormulaArg([][]formulaArg{{newNumberFormulaArg(1)}})}}), "", ""},
+		{"list_scalar_head", newListFormulaArg([]formulaArg{newNumberFormulaArg(12)}), "", "12"},
+		{"list_nested_head", newListFormulaArg([]formulaArg{newListFormulaArg([]formulaArg{newNumberFormulaArg(2)})}), "", ""},
+		{"list_empty", newListFormulaArg(nil), "", ""},
+	}
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			c := &xlsxC{T: "inlineStr", V: "stale", IS: &xlsxSI{}}
+
+			setCachedArg(c, tc.arg)
+
+			assert.Nil(t, c.IS)
+			assert.Equal(t, tc.wantT, c.T)
+			assert.Equal(t, tc.wantV, c.V)
+		})
+	}
+}