Skip to content

Commit 35dace8

Browse files
committed
WebUI: fix size-unit change not persisting when size fields are 0
The min/max size unit dropdowns were wired to a short-circuiting handler that skipped saving whenever both size inputs were 0, causing the unit to silently revert on tab switch or reload when "Remember filters" was enabled. Wire them to searchSizeFilterChanged directly, matching the Qt widget's behavior.
1 parent 2cf7e2b commit 35dace8

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

src/webui/www/private/scripts/search.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ window.qBittorrent.Search ??= (() => {
4141
pluginSelected: pluginSelected,
4242
searchSeedsFilterChanged: searchSeedsFilterChanged,
4343
searchSizeFilterChanged: searchSizeFilterChanged,
44-
searchSizeFilterPrefixChanged: searchSizeFilterPrefixChanged,
4544
searchRememberFiltersChanged: searchRememberFiltersChanged,
4645
closeSearchTab: closeSearchTab,
4746
};
@@ -950,11 +949,6 @@ window.qBittorrent.Search ??= (() => {
950949
searchFilterChanged();
951950
};
952951

953-
const searchSizeFilterPrefixChanged = () => {
954-
if ((Number(document.getElementById("searchMinSizeFilter").value) !== 0) || (Number(document.getElementById("searchMaxSizeFilter").value) !== 0))
955-
searchSizeFilterChanged();
956-
};
957-
958952
const searchFilterChanged = () => {
959953
searchResultsTable.updateTable();
960954
document.getElementById("numSearchResultsVisible").textContent = searchResultsTable.getFilteredAndSortedRows().length;

src/webui/www/private/views/search.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@
176176

177177
<label for="searchMinSizeFilter" style="margin-left: 15px;">QBT_TR(Size:)QBT_TR[CONTEXT=SearchEngineWidget]</label>
178178
<input type="number" min="0" max="1000" step=".01" value="0.00" id="searchMinSizeFilter" onchange="qBittorrent.Search.searchSizeFilterChanged()">
179-
<select id="searchMinSizePrefix" onchange="qBittorrent.Search.searchSizeFilterPrefixChanged()" aria-label="QBT_TR(Min size prefix)QBT_TR[CONTEXT=SearchEngineWidget]">
179+
<select id="searchMinSizePrefix" onchange="qBittorrent.Search.searchSizeFilterChanged()" aria-label="QBT_TR(Min size prefix)QBT_TR[CONTEXT=SearchEngineWidget]">
180180
<option value="0">QBT_TR(B)QBT_TR[CONTEXT=misc]</option>
181181
<option value="1">QBT_TR(KiB)QBT_TR[CONTEXT=misc]</option>
182182
<option value="2" selected>QBT_TR(MiB)QBT_TR[CONTEXT=misc]</option>
@@ -187,7 +187,7 @@
187187
</select>
188188
<label for="searchMaxSizeFilter">QBT_TR(to)QBT_TR[CONTEXT=SearchEngineWidget]</label>
189189
<input type="number" min="0" max="1000" step=".01" value="0.00" id="searchMaxSizeFilter" onchange="qBittorrent.Search.searchSizeFilterChanged()">
190-
<select id="searchMaxSizePrefix" onchange="qBittorrent.Search.searchSizeFilterPrefixChanged()" aria-label="QBT_TR(Max size prefix)QBT_TR[CONTEXT=SearchEngineWidget]">
190+
<select id="searchMaxSizePrefix" onchange="qBittorrent.Search.searchSizeFilterChanged()" aria-label="QBT_TR(Max size prefix)QBT_TR[CONTEXT=SearchEngineWidget]">
191191
<option value="0">QBT_TR(B)QBT_TR[CONTEXT=misc]</option>
192192
<option value="1">QBT_TR(KiB)QBT_TR[CONTEXT=misc]</option>
193193
<option value="2">QBT_TR(MiB)QBT_TR[CONTEXT=misc]</option>

0 commit comments

Comments
 (0)