Skip to content

Missing invocation of np.sin in custom_feature_map.ipynb #133

Open
@emanouil

Description

@emanouil

It seems to me the definition of custom_data_map_func in custom_feature_map.ipynb
does not correspond to the mathematical expression.

coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.pi - x)

gives the default function, when it should be
coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.sin(np.pi - x))

to be consistent with the text.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions