chore: update eslint to 9 (#1801)

Author: Caele

.eslintrc.json

@@ -1,4 +1,5 @@
 #! /usr/bin/env node
+/* eslint no-underscore-dangle: 0 */
 import { globbySync } from 'globby';
 import { fileURLToPath } from 'url';
 import fs from 'fs';
@@ -49,7 +50,6 @@ for (const fileName of LOCALES_FILES) {
       acc[key].locale = {};
     }
     acc[key].locale[locale] = content[curr].value;
-    const localeObj = acc[key].locale[locale];
     return acc;
   }, merged);
 }

apis/locale/scripts/generate-all.mjs

@@ -76,7 +76,7 @@ export default function ListBox({
   const scrollTimeout = 0;
 
   const { frequencyMax, awaitingFrequencyMax } = useFrequencyMax(app, layout);
-
+  // eslint-disable-next-line no-unused-vars
   const { isLoadingData, ...itemsLoader } = useItemsLoader({
     local,
     loaderRef,

apis/nucleus/src/components/listbox/ListBox.jsx

@@ -205,6 +205,7 @@ describe('ListBoxPortal', () => {
         option_two: '#02',
         __DO_NOT_USE__: doNotUse,
       };
+      // eslint-disable-next-line no-unused-vars
       const { __DO_NOT_USE__, ...resultOfOptions } = extraOptions;
       expect(getOptions(extraOptions)).toMatchObject({ ...defaultValues, ...resultOfOptions, ...doNotUse });
     });

apis/nucleus/src/components/listbox/__tests__/list-box-portal.test.jsx

@@ -82,6 +82,7 @@ const RowColRoot = styled('div', {
       'styles',
     ].includes(prop),
 })(({ theme, checkboxes, isGridMode, isGridCol, dense, direction, sizes, frequencyMode, freqHitsValue, styles }) => {
+  // eslint-disable-next-line no-unused-vars
   const { backgroundColor: _, ...contentFontStyles } = styles.content;
 
   const rowSelectionStyle = getRowSelectionStyle({ theme, styles, checkboxes, selectionState: 'selected' });

apis/nucleus/src/components/listbox/components/ListBoxRowColumn/components/ListBoxRoot.jsx

@@ -0,0 +1,185 @@
+import { defineConfig, globalIgnores } from 'eslint/config';
+import prettier from 'eslint-plugin-prettier';
+import jest from 'eslint-plugin-jest';
+import globals from 'globals';
+import mocha from 'eslint-plugin-mocha';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default defineConfig([
+  globalIgnores(['**/dist/', '**/coverage/', '**/node_modules/', 'apis/snapshooter/client.js', 'apis/*/core/**/*.js']),
+  {
+    extends: compat.extends('airbnb', 'prettier'),
+
+    plugins: {
+      prettier,
+      jest,
+    },
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...jest.environments.globals.globals,
+        __NEBULA_DEV__: false,
+      },
+
+      ecmaVersion: 2020,
+      sourceType: 'module',
+    },
+
+    rules: {
+      'max-len': 0,
+      'no-plusplus': 0,
+      'no-bitwise': 0,
+      'no-unused-expressions': 0,
+      'prettier/prettier': 2,
+      'react/destructuring-assignment': [0, 'always'],
+      'react/prop-types': 0,
+      'react/no-deprecated': 0,
+
+      'import/no-extraneous-dependencies': [
+        2,
+        {
+          devDependencies: true,
+        },
+      ],
+
+      'import/no-dynamic-require': 0,
+      'jest/no-disabled-tests': 'warn',
+      'jest/no-focused-tests': 'error',
+      'jest/no-identical-title': 'error',
+      'jest/prefer-to-have-length': 'warn',
+      'jest/valid-expect': 'error',
+      'no-unused-vars': [
+        'error',
+        {
+          caughtErrors: 'none',
+        },
+      ],
+    },
+  },
+  {
+    files: ['apis/**/*', 'packages/**/*', 'commands/create/**/*', 'commands/sense/src/**/*'],
+
+    rules: {
+      'jest/valid-expect': 0,
+      'jest/no-identical-title': 0,
+    },
+  },
+  {
+    files: ['scripts/**/*', '**/apis/*/scripts/**/*'],
+
+    rules: {
+      'no-restricted-syntax': 0,
+    },
+  },
+  {
+    files: ['apis/**/*'],
+
+    rules: {
+      'no-console': 'error',
+    },
+  },
+  {
+    files: ['apis/*/index.js'],
+
+    rules: {
+      'global-require': 0,
+    },
+  },
+  {
+    files: ['commands/sense/src/*.js'],
+
+    languageOptions: {
+      globals: {
+        define: false,
+      },
+    },
+
+    rules: {
+      'no-var': 0,
+      'import/no-amd': 0,
+    },
+  },
+  {
+    files: ['commands/serve/web/**/*.{js,jsx}'],
+
+    rules: {
+      'arrow-body-style': 1,
+      'no-use-before-define': 1,
+      'react/function-component-definition': 0,
+      'import/prefer-default-export': 1,
+      'import/no-cycle': 1,
+    },
+  },
+  {
+    files: ['commands/serve/web/**/*.test.{js,jsx}', 'commands/serve/web/utils/testRenderer.jsx'],
+
+    rules: {
+      'import/no-extraneous-dependencies': 0,
+      'array-callback-return': 0,
+    },
+  },
+  {
+    files: ['**/*.{int,comp,spec}.{js,jsx}'],
+
+    plugins: {
+      mocha,
+    },
+
+    languageOptions: {
+      globals: {
+        ...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, 'off'])),
+        ...globals.node,
+        ...globals.mocha,
+        chai: false,
+        expect: false,
+        sinon: false,
+        page: false,
+      },
+    },
+
+    rules: {
+      'mocha/no-exclusive-tests': 'error',
+    },
+  },
+  {
+    files: ['**/*.{int,comp}.js'],
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+      },
+    },
+  },
+  {
+    files: ['**/templates/**/*.js'],
+
+    rules: {
+      'import/no-unresolved': 0,
+      'import/extensions': 0,
+      'import/no-extraneous-dependencies': 0,
+    },
+  },
+  {
+    files: ['**/website/**/*.js'],
+
+    rules: {
+      'react/jsx-filename-extension': 0,
+      'react/no-multi-comp': 0,
+      'react/prefer-stateless-function': 0,
+      'import/no-extraneous-dependencies': 0,
+      'import/no-unresolved': 0,
+    },
+  },
+]);

eslint.config.mjs

@@ -61,7 +61,7 @@
     "cross-env": "10.0.0",
     "css-loader": "7.1.2",
     "enigma.js": "2.14.0",
-    "eslint": "8.57.1",
+    "eslint": "9.35.0",
     "eslint-config-airbnb": "19.0.4",
     "eslint-config-prettier": "10.1.8",
     "eslint-plugin-import": "2.32.0",
@@ -71,6 +71,7 @@
     "eslint-plugin-prettier": "5.5.4",
     "eslint-plugin-react": "7.37.5",
     "express": "5.1.0",
+    "globals": "^16.3.0",
     "husky": "9.1.7",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",