Skip to content

[Bug] Oneshot locked modifier is not disabled on the next modifier key press after toggling #25106

Open
@denis-savran

Description

@denis-savran

Describe the Bug

If you toggle a oneshot locked modifier and then press the modifier key again to disable it, the modifier remains active in an OS until the next key press on a keyboard.

Steps to reproduce:

  1. Toggle Shift by pressing it two times.
  2. Press Shift one time.

Actual behavior:

The Shift modifier is not disabled right after pressing the modifier key.
It remains active in an OS.

To disable it in the OS you have to press some key on a keyboard (the modifier is not applied), trigger a hold event for the modifier key or restart the keyboard.

Expected behavior:

The Shift modifier is disabled right after pressing the modifier key.

This bug breaks the following usage scenario:

  1. Select the first item using a mouse.
  2. Toggle Shift by pressing it two times.
  3. Click on the second item to select several items.
  4. Disable Shift by pressing it one time.
  5. Perform some action with the selection.

Keyboard Used

moonlander

Link to product page (if applicable)

https://www.zsa.io/moonlander

Operating System

Ubuntu 22.04

qmk doctor Output


Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions