From 5a35881d2ff174288bb43a1b6be6c16414cd79be Mon Sep 17 00:00:00 2001 From: zvecr Date: Tue, 15 Apr 2025 02:18:16 +0100 Subject: [PATCH] Require url field to not be empty --- data/schemas/keyboard.jsonschema | 3 ++- lib/python/qmk/cli/lint.py | 11 ----------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/data/schemas/keyboard.jsonschema b/data/schemas/keyboard.jsonschema index 4e8bae1084f8..92521427c759 100644 --- a/data/schemas/keyboard.jsonschema +++ b/data/schemas/keyboard.jsonschema @@ -46,7 +46,8 @@ "manufacturer": {"$ref": "qmk.definitions.v1#/text_identifier"}, "url": { "type": "string", - "format": "uri" + "format": "uri", + "minLength": 1 }, "development_board": { "type": "string", diff --git a/lib/python/qmk/cli/lint.py b/lib/python/qmk/cli/lint.py index e2c76e4465f2..bc14b61e8b4c 100644 --- a/lib/python/qmk/cli/lint.py +++ b/lib/python/qmk/cli/lint.py @@ -171,14 +171,6 @@ def _handle_invalid_features(kb, info): return ok -def _handle_invalid_config(kb, info): - """Check for invalid keyboard level config - """ - if info.get('url') == "": - cli.log.warning(f'{kb}: Invalid keyboard level config detected - Optional field "url" should not be empty.') - return True - - def _chibios_conf_includenext_check(target): """Check the ChibiOS conf.h for the correct inclusion of the next conf.h """ @@ -263,9 +255,6 @@ def keyboard_check(kb): # noqa C901 if not _handle_invalid_features(kb, kb_info): ok = False - if not _handle_invalid_config(kb, kb_info): - ok = False - invalid_files = git_get_ignored_files(f'keyboards/{kb}/') for file in invalid_files: if 'keymap' in file: