fix: revert permissive default and mock scope validation in integration tests

Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>

Author: 2 people

packages/features/feature-opt-in/config.ts

@@ -68,10 +68,10 @@ export function getOptInFeaturesForScope(scope: OptInFeatureScope): OptInFeature
 /**
  * Check if a feature is allowed for a specific scope.
  * Features without a scope field are allowed for all scopes.
- * Features not in the config are allowed for all scopes (permissive by default).
+ * Features not in the config are NOT allowed (must be explicitly configured).
  */
 export function isFeatureAllowedForScope(slug: string, scope: OptInFeatureScope): boolean {
   const config = getOptInFeatureConfig(slug);
-  if (!config) return true;
+  if (!config) return false;
   return !config.scope || config.scope.includes(scope);
 }

packages/features/feature-opt-in/services/FeatureOptInService.integration-test.ts

@@ -1,4 +1,4 @@
-import { afterEach, describe, expect, it } from "vitest";
+import { afterEach, describe, expect, it, vi } from "vitest";
 
 import { getFeatureOptInService } from "@calcom/features/di/containers/FeatureOptInService";
 import { getFeaturesRepository } from "@calcom/features/di/containers/FeaturesRepository";
@@ -8,6 +8,16 @@ import { prisma } from "@calcom/prisma";
 
 import type { IFeatureOptInService } from "./IFeatureOptInService";
 
+// Mock isFeatureAllowedForScope to always return true for integration tests.
+// The scope validation logic is tested in unit tests; integration tests focus on database behavior.
+vi.mock("../config", async (importOriginal) => {
+  const actual = await importOriginal<typeof import("../config")>();
+  return {
+    ...actual,
+    isFeatureAllowedForScope: () => true,
+  };
+});
+
 // Helper to generate unique identifiers per test
 const uniqueId = () => `${Date.now()}-${Math.random().toString(36).slice(2, 9)}`;