Skip to content

Commit e329e21

Browse files
committed
fix(yield-wrapper): prevent circular reference in node replacement
Add safety check to filter out wrapper element from nodes to avoid DOM circular reference error when replacing nodes in YieldWrapper component.
1 parent 412373a commit e329e21

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

react-migration-toolkit/src/components/yield-wrapper.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@ export const YieldWrapper: React.FC<YieldWrapperProps> = ({ nodes }) => {
1212

1313
if (element?.parentNode) {
1414
const fragment = document.createDocumentFragment();
15-
for (const node of nodes) {
15+
16+
// Filter out the wrapper element itself from the nodes to prevent circular reference
17+
const filteredNodes = nodes.filter((node) => node !== element);
18+
19+
for (const node of filteredNodes) {
1620
fragment.appendChild(node);
1721
}
1822

0 commit comments

Comments
 (0)