Skip to content

Commit b0359be

Browse files
authored
Merge pull request #665 from qonversion/tech/sc-38454/publishFix
Updated JVM compatibility and Kotlin version to fix publishing.
2 parents 7e9b460 + bddcfed commit b0359be

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ buildscript {
1010
versionCode: 1
1111
]
1212
}
13-
ext.kotlin_version = '1.8.22'
13+
ext.kotlin_version = '1.9.25'
1414
repositories {
1515
mavenCentral()
1616
google()

sdk/build.gradle

+3-8
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ android {
1919
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
2020
}
2121

22-
kotlinOptions {
23-
jvmTarget = '18'
24-
}
25-
2622
buildTypes {
2723
buildTypes.each {
2824
it.buildConfigField("String","VERSION_NAME", "\"${defaultConfig.versionName}\"")
@@ -33,9 +29,8 @@ android {
3329
}
3430
}
3531

36-
compileOptions {
37-
sourceCompatibility JavaVersion.VERSION_18
38-
targetCompatibility JavaVersion.VERSION_18
32+
kotlin {
33+
jvmToolchain(18)
3934
}
4035

4136
testOptions {
@@ -67,7 +62,7 @@ ext {
6762
PUBLISH_GROUP_ID = 'io.qonversion.android.sdk'
6863
PUBLISH_ARTIFACT_ID = 'sdk'
6964

70-
moshiVersion = '1.14.0'
65+
moshiVersion = '1.15.2'
7166
retrofit_version = '2.9.0'
7267
okhttp_version = '3.12.13'
7368
billing = '7.0.0'

sdk/src/test/java/com/qonversion/android/sdk/internal/QIdentityManagerTest.kt

+7-7
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ internal class QIdentityManagerTest {
3939

4040
// when
4141
identityManager.identify(newUserID, object : IdentityManagerCallback {
42-
override fun onSuccess(identityID: String) {
43-
resultUserID = identityID
42+
override fun onSuccess(qonversionUid: String) {
43+
resultUserID = qonversionUid
4444
}
4545
override fun onError(error: QonversionError) {}
4646
})
@@ -62,8 +62,8 @@ internal class QIdentityManagerTest {
6262

6363
// when
6464
identityManager.identify(newUserID, object : IdentityManagerCallback {
65-
override fun onSuccess(identityID: String) {
66-
resultUserID = identityID
65+
override fun onSuccess(qonversionUid: String) {
66+
resultUserID = qonversionUid
6767
}
6868
override fun onError(error: QonversionError) {}
6969
})
@@ -84,7 +84,7 @@ internal class QIdentityManagerTest {
8484

8585
// when
8686
identityManager.identify(newUserID, object : IdentityManagerCallback {
87-
override fun onSuccess(identityID: String) {}
87+
override fun onSuccess(qonversionUid: String) {}
8888
override fun onError(error: QonversionError) {}
8989
})
9090

@@ -109,7 +109,7 @@ internal class QIdentityManagerTest {
109109

110110
// when
111111
identityManager.identify(newUserID, object : IdentityManagerCallback {
112-
override fun onSuccess(identityID: String) {}
112+
override fun onSuccess(qonversionUid: String) {}
113113
override fun onError(error: QonversionError) {}
114114
})
115115

@@ -140,7 +140,7 @@ internal class QIdentityManagerTest {
140140

141141
// when
142142
identityManager.identify(newUserID, object : IdentityManagerCallback {
143-
override fun onSuccess(identityID: String) {}
143+
override fun onSuccess(qonversionUid: String) {}
144144
override fun onError(error: QonversionError) {
145145
qError = error
146146
}

settings.gradle

+6-1
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1-
include ':sdk', ':sample'
1+
plugins {
2+
// https://kotlinlang.org/docs/gradle-configure-project.html#set-jdk-version-with-the-task-dsl
3+
id("org.gradle.toolchains.foojay-resolver-convention") version("0.9.0")
4+
}
5+
6+
include ':sdk', ':sample'

0 commit comments

Comments
 (0)