Merge pull request #373 from lool/silent-pipeline-failures

Fix silent pipeline failures

Author: lool

debos-recipes/qualcomm-linux-debian-flash.yaml

@@ -446,8 +446,9 @@ actions:
           [ -f "${contents_xml}" ] || continue
           spinor_dir_name="$(basename "${spinor_dir}")"
           board="${spinor_dir_name#flash_}"; board="${board%_spinor}"
-          xmlstarlet sel -t -m "//product_info/chipid" -v "@storage_type" -n "${contents_xml}" | \
-              tr '[:upper:]' '[:lower:]' | sort -u | \
+          # extract storage types to variable to avoid silent pipeline failure
+          storage_types=$(xmlstarlet sel -t -m "//product_info/chipid" -v "@storage_type" -n "${contents_xml}")
+          echo "$storage_types" | tr '[:upper:]' '[:lower:]' | sort -u | \
               while read -r storage; do
                   [ "${storage}" = "spinor" ] && continue
                   target_dir="${ARTIFACTDIR}/flash_${board}_${storage}"

debos-recipes/qualcomm-linux-debian-image.yaml

@@ -108,8 +108,9 @@ actions:
       # when building under debos, /sys/firmware/efi is not always present, so
       # the u-boot-efi-dtb postinst doesn't install an initial copy of the
       # DTBs; do this once here
-      latest_kernel="$(
-          linux-version list | linux-version sort --reverse | head -1)"
+      # extract kernel list to variable to avoid silent pipeline failure
+      kernel_list=$(linux-version list)
+      latest_kernel=$(echo "$kernel_list" | linux-version sort --reverse | head -1)
       dtb_path="/usr/lib/linux-image-${latest_kernel}"
       cp -LRT "$dtb_path" "/boot/efi/dtb"
 
@@ -147,8 +148,9 @@ actions:
       set -eux
       sector_size="{{if eq $imagetype "ufs"}}4096{{else}}512{{end}}"
       image="{{ $image }}"
-      fdisk -b "${sector_size}" -l "${image}" |
-          sed -n '1,/^Device/ d; p' |
+      # extract fdisk output to variable to avoid silent pipeline failure
+      fdisk_output=$(fdisk -b "${sector_size}" -l "${image}")
+      echo "$fdisk_output" | sed -n '1,/^Device/ d; p' |
           while read name start end sectors rest; do
               dd if="${image}" of="${ARTIFACTDIR}/${name}" \
                   bs="${sector_size}" skip="${start}" count="${sectors}"

debos-recipes/qualcomm-linux-debian-rootfs.yaml

@@ -374,8 +374,9 @@ actions:
       # this image has pulled a more recent kernel, it's probably to gain
       # support for new hardware which would happen through new or updated dtbs
       # only in that new kernel, so use the latest dtbs
-      latest_kernel="$(
-          ls -d "$ROOTDIR"/usr/lib/linux-image-* | sort -V | tail -1)"
+      # list kernel directories to avoid silent pipeline failure
+      kernel_dirs=$(ls -d "$ROOTDIR"/usr/lib/linux-image-*)
+      latest_kernel=$(echo "$kernel_dirs" | sort -V | tail -1)
       # transform pathnames to strip the leading ./
       tar \
           -C "${latest_kernel}" \