test(e2e): render smoke assertion as native Midscene step

Author: quanru

.github/workflows/midscene-omarchy-4.0.3.yml

@@ -25,6 +25,7 @@ on:
       - "tests/e2e/cases/**"
       - "tests/e2e/midscene.config.ts"
       - "tests/e2e/model-rate-gate.mjs"
+      - "tests/e2e/render-omarchy-plugin-smoke.mjs"
       - "tests/e2e/run-omarchy-midscene.sh"
       - "tests/e2e/restore-omarchy-vm.sh"
       - "tests/e2e/omarchy-vm.env"

tests/e2e/cases/omarchy-plugin-smoke.yaml

@@ -2,4 +2,4 @@ cases:
   - name: Review a pinned community plugin on the real Omarchy desktop
     steps:
       - review.openConfigured: {}
-      - review.assertConfiguredVisual: {}
+      - aiAssert: __REVIEW_VISIBLE_ASSERTION__

tests/e2e/midscene.config.ts

@@ -387,15 +387,6 @@ const openConfiguredReviewPlugin = defineNode<typeof empty, void, DesktopContext
     throw new Error(`Plugin IPC did not become ready: ${String(lastError)}`);
   },
 });
-const assertConfiguredReviewPlugin = defineNode<typeof empty, void, DesktopContext>({
-  name: 'review.assertConfiguredVisual', description: 'Assert the caller-provided visible behavior on the real Omarchy desktop.', inputSchema: empty,
-  async execute({ context }) {
-    const assertion = process.env.REVIEW_VISIBLE_ASSERTION;
-    if (!assertion || assertion.length > 500) throw new Error('REVIEW_VISIBLE_ASSERTION must be 1–500 characters');
-    if (!context.agent) throw new Error('Midscene Computer Agent is not active');
-    await context.agent.aiAssert(assertion);
-  },
-});
 
 const productCaseFiles = [
   'cases/onboarding.yaml',
@@ -510,6 +501,5 @@ export default defineTestProject<DesktopContext>({
     openReviewPlugin,
     assertReviewPluginEmpty,
     openConfiguredReviewPlugin,
-    assertConfiguredReviewPlugin,
   ],
 });

tests/e2e/render-omarchy-plugin-smoke.mjs

@@ -0,0 +1,15 @@
+import { readFileSync, writeFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+
+const assertion = process.env.REVIEW_VISIBLE_ASSERTION;
+if (!assertion || assertion.length > 500) {
+  throw new Error('REVIEW_VISIBLE_ASSERTION must be 1–500 characters');
+}
+
+const casePath = fileURLToPath(new URL('./cases/omarchy-plugin-smoke.yaml', import.meta.url));
+const source = readFileSync(casePath, 'utf8');
+const placeholder = '__REVIEW_VISIBLE_ASSERTION__';
+if (source.split(placeholder).length !== 2) {
+  throw new Error('Plugin smoke case must contain one assertion placeholder');
+}
+writeFileSync(casePath, source.replace(placeholder, JSON.stringify(assertion)));

tests/e2e/run-omarchy-midscene.sh

@@ -281,7 +281,11 @@ case "$MIDSCENE_PROJECT" in
   omarchy-shard-[1-4])
     npm --prefix tests/e2e test -- --project "$MIDSCENE_PROJECT"
     ;;
-  omarchy-shell|omarchy-plugin-review|omarchy-plugin-smoke)
+  omarchy-plugin-smoke)
+    node tests/e2e/render-omarchy-plugin-smoke.mjs
+    npm --prefix tests/e2e test -- --project "$MIDSCENE_PROJECT"
+    ;;
+  omarchy-shell|omarchy-plugin-review)
     npm --prefix tests/e2e test -- --project "$MIDSCENE_PROJECT"
     ;;
   *)