Skip to content

Commit b438db9

Browse files
committed
feat(e2e): summon panel plugins in visual review
1 parent a9ecca2 commit b438db9

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

‎.github/workflows/midscene-omarchy-4.0.3.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ on:
7171
type: string
7272
required: false
7373
plugin_open_method:
74-
description: Plugin IPC method that opens its UI, usually open
74+
description: Use summon for panel/overlay/menu, or a plugin IPC method such as open
7575
type: string
7676
required: false
7777
default: open

‎tests/e2e/OMARCHY_PLUGIN_REVIEW.md‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,14 @@ gh workflow run midscene-omarchy-4.0.3.yml \
2323

2424
The equivalent form is under **Actions → Omarchy 4.0.3 → Run workflow**. Enter
2525
the plugin's GitHub `owner/repository`, full 40-character commit SHA, manifest
26-
ID, shell IPC method that opens the UI, and one visible result to check. The
26+
ID, shell action that opens the UI (`summon` for panels, overlays, and menus;
27+
an IPC method such as `open` for bar widgets), and one visible result to check. The
2728
input is bound to the exact commit; the runner does not follow the upstream
2829
branch after validation. The workflow uploads the native Midscene HTML replay
2930
and screenshots as `omarchy-midscene-omarchy-plugin-smoke`.
3031

31-
This pilot supports bar widgets with an IPC method that opens their UI. A visual
32+
This pilot supports shell-summoned panels, overlays, menus, and bar widgets with
33+
an IPC method that opens their UI. A visual
3234
assertion is useful review evidence, but it is not a security verdict. The
3335
Checklist Todo case additionally verifies state and disk persistence because a
3436
visual model can miss a tiny control or misread a closed popup as an empty one.

‎tests/e2e/midscene.config.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ const assertReviewPluginEmpty = defineNode<typeof empty, void, DesktopContext>({
367367
},
368368
});
369369
const openConfiguredReviewPlugin = defineNode<typeof empty, void, DesktopContext>({
370-
name: 'review.openConfigured', description: 'Open the exact-commit plugin through its declared shell IPC method.', inputSchema: empty,
370+
name: 'review.openConfigured', description: 'Open the exact-commit plugin through shell summon or its declared IPC method.', inputSchema: empty,
371371
async execute() {
372372
const id = process.env.REVIEW_PLUGIN_ID;
373373
const method = process.env.REVIEW_PLUGIN_OPEN_METHOD || 'open';
@@ -376,7 +376,10 @@ const openConfiguredReviewPlugin = defineNode<typeof empty, void, DesktopContext
376376
let lastError: unknown;
377377
for (let attempt = 0; attempt < 20; attempt++) {
378378
try {
379-
guest(`omarchy-shell ${shellQuote(id)} ${shellQuote(method)}`);
379+
const command = method === 'summon' || method === 'toggle'
380+
? `omarchy-shell shell ${method} ${shellQuote(id)} '{}'`
381+
: `omarchy-shell ${shellQuote(id)} ${shellQuote(method)}`;
382+
guest(command);
380383
await sleep(1000);
381384
return;
382385
} catch (error) {

0 commit comments

Comments
 (0)