Skip to content

Delete unused dataclass cirq_google.CalibrationResult #7677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Delete unused dataclass cirq_google.CalibrationResult #7677

merged 1 commit into from
Sep 30, 2025

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Sep 29, 2025 •
edited
Loading

Commit e76702f (#6442) deprecated the cirq_google.CalibrationResult
class and removed its serialization test data. The class does not appear
to have any callers in the Cirq codebase.

@pavoljuhas
Delete unused dataclass cirq_google.CalibrationResult
9eb24a3 
Commit e76702f (quantumlib#6442) deprecated the `cirq_google.CalibrationResult`
class and removed its serialization test data.  The class does not appear
to have any callers in the Cirq code.
@pavoljuhas pavoljuhas requested review from a team, verult, vtomole and wcourtney as code owners September 29, 2025 22:59
@github-actions github-actions bot added the size: M 50< lines changed <250 label Sep 29, 2025
@pavoljuhas pavoljuhas mentioned this pull request Sep 29, 2025
Merged
@pavoljuhas
Copy link
Collaborator Author

pavoljuhas commented Sep 29, 2025 •
edited
Loading

@wcourtney, @dstrain115 - should we go through with a deprecation-warning release before this removal? The CalibrationResult appears to be disconnected from the rest of the code since #6442 so I am not sure if it is worth to do the deprecation.

@codecov Codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (82d2cdc) to head (9eb24a3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7677      +/-   ##
==========================================
- Coverage   99.37%   99.37%   -0.01%     
==========================================
  Files        1085     1084       -1     
  Lines       96937    96917      -20     
==========================================
- Hits        96331    96311      -20     
  Misses        606      606

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@senecameeks
Copy link
Collaborator

@wcourtney, @dstrain115 - should we go through with a deprecation-warning release before this removal? The CalibrationResult appears to be disconnected from the rest of the code since #6442 so I am not sure if it is worth to do the deprecation.

@pavoljuhas cirq_google does not have the same backwards compatibility requirements as cirq. This dataclass hasn't been used in at least 2 years so I think it's safe to remove.

@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 30, 2025
@pavoljuhas pavoljuhas added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Sep 30, 2025
Merged via the queue into quantumlib:main with commit efb296e Sep 30, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the delete-unused-calibrationresult branch September 30, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@senecameeks senecameeks senecameeks approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney wcourtney is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@verult verult Awaiting requested review from verult verult is a code owner

Assignees

No one assigned

Labels

BREAKING CHANGE For pull requests that are important to mention in release notes. size: M 50< lines changed <250

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavoljuhas @senecameeks