Skip to content

Likely code errors in isdf.py #924

Open
@mhucka

Description

@mhucka

In src/openfermion/resource_estimates/pbc/thc/factorizations/isdf.py at lines 587-589, a variable is getting assigned to itself, which is probably an error:

    else:
        delta_gs = [g_vectors] * num_kpts
        g_mapping = g_mapping

Around lines 912-917, the same thing happens with another variable:

    elif kmeans_weighting_function == "sum_squares":
        # w(r) = sum_{i} |phi_{ki}(r)|
        weighting_function = np.einsum(
            "kRi,kRi->R", bloch_orbitals_mo.conj(), bloch_orbitals_mo, optimize=True
        )
        weighting_function = weighting_function

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions