Merge branch 'master' into mh-fix-403

Author: mhucka

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -0,0 +1,31 @@
+name: Bug report
+description: Report a problem with this software or project
+type: Bug
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for taking the time to fill out this bug report!
+
+  - type: textarea
+    attributes:
+      label: Describe the issue
+      description: >-
+        Please explain clearly and in detail what the issue is. What led up
+        to it, or how did you encounter it?
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: How can the issue be reproduced?
+      description: >-
+        Explain in a step-by-step fashion what someone else would need to
+        do in order to reproduce the issue. If possible, include literal
+        examples of commands or code using [Markdown fenced code
+        blocks](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks).
+        For long output, paste the text into [collapsed
+        sections](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections)
+        or attach text files.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/2-feature-request.yml

@@ -0,0 +1,43 @@
+name: Feature request
+description: Request a new feature or change
+type: Enhancement
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for taking the time to fill out this feature request form!
+
+  - type: textarea
+    attributes:
+      label: Is your feature request related to a use case or problem?
+      description: >-
+        Please tell us the context of your request. Is it to help you do
+        something that you currently cannot due to limitations in the software,
+        or is it an idea for an enhancement or new functionality, or something
+        else?
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: What solution or approach do you envision?
+      description: >-
+        If you have ideas or preferences for the solution, you can let us know
+        here. If you are aware of other similar or related work, please let us
+        know about it here.
+    validations:
+      required: false
+
+  - type: dropdown
+    attributes:
+      label: How urgent is this for you?
+      description: >-
+        Please choose from among the following options. If the lack of this
+        feature is blocking important work, please choose from among P0–P2.
+      options:
+        - P0 – needed no later than a week
+        - P1 – needed by the next release
+        - P2 – needed within two quarters
+        - P3 – not blocked; it's an idea
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/3-task.yml

@@ -0,0 +1,34 @@
+name: Task
+description: Describe a task that needs to be done
+type: Task
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for taking the time to fill out this feature request form!
+
+  - type: textarea
+    attributes:
+      label: What is the task?
+    validations:
+      required: true
+
+  - type: textarea
+    attributes:
+      label: (Optional) Do you have ideas or preferences for the approach?
+    validations:
+      required: false
+
+  - type: dropdown
+    attributes:
+      label: How urgent is this for you?
+      description: >-
+        Please choose from among the following options. If the lack of this
+        feature is blocking important work, please choose from among P0–P2.
+      options:
+        - P0 – needed no later than a week
+        - P1 – needed by the next release
+        - P2 – needed within two quarters
+        - P3 – not blocked; it's an idea
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: true

.github/SECURITY.md

@@ -1,19 +1,25 @@
 # Reporting security issues
 
-The ReCirq developers and community take security bugs in ReCirq seriously.
-We appreciate your efforts to responsibly disclose your findings, and will make
-every effort to acknowledge your contributions.
+This project's developers and community are committed to addressing security
+bugs promptly and effectively. We appreciate your efforts to disclose your
+findings responsibly, and will make every effort to acknowledge your
+contributions.
 
 Please **do not** use GitHub issues to report security vulnerabilities; GitHub
 issues are public, and doing so could allow someone to exploit the information
-before the problem can be addressed. Instead, please use the GitHub ["Report
-a Vulnerability"](https://github.com/quantumlib/recirq/security/advisories/new)
-interface from the _Security_ tab of the ReCirq repository.
+before the problem can be addressed. Instead, please use the *Report a
+vulnerability* interface from the *Security* tab at the top of this GitHub
+repository page.
+
+<div align="center">
+<img width="75%" alt="Location of the report button on the repository page"
+    src="/.github/report-vulnerability-button.png">
+</div>
 
 Please report security issues in third-party modules to the person or team
-maintaining the module rather than the  project stewards, unless you
-believe that some action needs to be taken with ReCirq in order to guard
-against the effects of a security vulnerability in a third-party module.
+maintaining the module rather than this project's stewards, unless you believe
+that some action needs to be taken specifically with this project in order to
+guard against the effects of a security vulnerability in third-party software.
 
 ## Responses to security reports
 
@@ -27,4 +33,4 @@ announcement, and may ask for additional information or guidance.
 Please contact the project stewards at Google Quantum AI via email at
 [email protected] if you have questions or other concerns. If
 for any reason you are uncomfortable reaching out to the project stewards,
-please email [email protected].
+please email [email protected] instead.

.github/report-vulnerability-button.png

@@ -175,7 +175,7 @@
     "    all_bitstrings = [ba.bits for ba in record['all_bitstrings']]\n",
     "    \n",
     "    # Compute <Z>\n",
-    "    record['z_vals'] = [np.mean((-1)**bitstrings, axis=0).item() for bitstrings in all_bitstrings]\n",
+    "    record['z_vals'] = [np.mean((-1)**bitstrings.astype(np.int8), axis=0).item() for bitstrings in all_bitstrings]\n",
     "    \n",
     "    # Don't need to carry around the full array of bits anymore\n",
     "    del record['all_bitstrings']\n",

docs/guide/data_analysis.ipynb

@@ -39,7 +39,7 @@ The circuit is constructed on a 6x6 grid of qubits. Let $L$ be the system linear
 
 After these steps, projective measurement in the $Z$ basis is performed on the preparation qubits (solid red in the figure below) to prepare the probe qubits' states (solid green). Shadow measurements are then performed on the probe qubits using the $X$, $Y$, and $Z$ bases with equal probability to collect data.
 
-The nearest-neighbor gate $e^{i(\pi/4)\sum_{\langle j,k \rangle} Z_j Z_k}$ is implemented by first applying a controlled-$Z$ ($\mathrm{CZ}$) gate between each pair of qubits, followed by local $Z^{-1/2}$ on both qubits, i.e., $\mathrm{CZ}_{jk}Z_j^{-1/2}Z_k^{-1/2}$. All nearest-neighbor two-qubit gates are applied in the following sequence to maintain constant circuit depth as the system size scales up: first, odd horizontal links; then, even horizontal links; followed by odd vertical links and finally even vertical links.
+The nearest-neighbor gate $e^{i(\pi/4)\sum_{\langle j,k \rangle} Z_j Z_k}$ is implemented by first applying a controlled-$Z$ ($\mathrm{CZ}$) gate between each pair of qubits, followed by local $Z^{-1/2}$ on both qubits, i.e., $Z_j^{-1/2}Z_k^{-1/2}\mathrm{CZ}_{jk}$. All nearest-neighbor two-qubit gates are applied in the following sequence to maintain constant circuit depth as the system size scales up: first, odd horizontal links; then, even horizontal links; followed by odd vertical links and finally even vertical links.
 
 ![Experimental realization of the circuit on quantum chip with 6x6 lattice at d=5.](grid_d=5.png)
 

recirq/cluster_state_mipt/README.md

@@ -92,7 +92,7 @@ def compute_opdm(
 
             variance_dict['xy_even'][circuit_idx] = even_cov_mat
             w, _ = np.linalg.eigh(even_cov_mat * len(data[q0_a]))
-            if not np.alltrue(w >= 0):
+            if not np.all(w >= 0):
                 raise ValueError(
                     "covariance matrix for xy_even:{} not postiive semidefinite"
                     .format(circuit_idx))
@@ -111,11 +111,11 @@ def compute_opdm(
 
             variance_dict['xy_odd'][circuit_idx] = odd_cov_mat
             w, _ = np.linalg.eigh(odd_cov_mat * len(data[q0_a]))
-            if not np.alltrue(w >= 0):
+            if not np.all(w >= 0):
                 raise ValueError(
                     "covariance matrix for xy_odd:{} not postiive semidefinite".
                     format(circuit_idx))
-            assert np.alltrue(w >= 0)
+            assert np.all(w >= 0)
 
         if circuit_idx == 0:  # No re-ordering
             for qubit_idx, q in enumerate(qubits):
@@ -168,7 +168,7 @@ def cov_func(i, j, p, q):
                     cov_func(j, i, p, q) + cov_func(j, i, q, p))
 
         w, _ = np.linalg.eigh(even_cov_mat)
-        if not np.alltrue(w >= 0):
+        if not np.all(w >= 0):
             raise ValueError(
                 "covariance matrix for xy_even:{} not postiive semidefinite".
                 format(circuit_idx))
@@ -183,7 +183,7 @@ def cov_func(i, j, p, q):
                     cov_func(i, j, p, q) + cov_func(i, j, q, p) +
                     cov_func(j, i, p, q) + cov_func(j, i, q, p))
         w, _ = np.linalg.eigh(odd_cov_mat)
-        if not np.alltrue(w >= 0):
+        if not np.all(w >= 0):
             raise ValueError(
                 "covariance matrix for xy_odd:{} not postiive semidefinite".
                 format(circuit_idx))
@@ -196,7 +196,7 @@ def cov_func(i, j, p, q):
                 for cidx, p in enumerate(range(num_qubits)):
                     z_cov_mat[ridx, cidx] = cov_func(i, i, p, p)
             w, _ = np.linalg.eigh(z_cov_mat)
-            if not np.alltrue(w >= -1.0E-15):
+            if not np.all(w >= -1.0E-15):
                 raise ValueError(
                     "covariance matrix for z:{} not postiive semidefinite".
                     format(circuit_idx))