Skip to content

Commit d889112

Browse files
authored
Merge branch 'master' into mh-fix-404
2 parents 1756707 + 3e0ed4e commit d889112

File tree

3 files changed

+45
-2
lines changed

3 files changed

+45
-2
lines changed

.github/workflows/pythonpackage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
- name: Install dependencies
3939
run: |
4040
python -m pip install --upgrade pip
41+
pip install -r requirements.txt
4142
python dev_tools/write-ci-requirements.py --relative-cirq-version=${{ matrix.cirq-version }} --all-extras
4243
pip install -r ci-requirements.txt
4344
pip install --no-deps -e .
@@ -52,7 +53,6 @@ jobs:
5253
5354
- name: Test with pytest
5455
run: |
55-
pip install pytest
5656
# RECIRQ_IMPORT_FAILSAFE: skip tests on unsupported Cirq configurations
5757
# EXPORT_OMP_NUM_THREADS: pyscf has poor openmp performance which slows down qcqmc tests.
5858
export OMP_NUM_THREADS=1

CONTRIBUTING.md

Lines changed: 43 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,49 @@ Guides](https://google.github.io/styleguide/) in your code, particularly the
6969

7070
### Development and testing
7171

72-
Do your work and `git commit` your changes to your branch as needed.
72+
Before you begin developing ReCirq experiments and modules, we recommend you
73+
first create a virtual Python environment. You can use either Python's built-in
74+
[`venv`](https://docs.python.org/3/library/venv.html) module or another tool
75+
that you are comfortable with.
76+
77+
Then, in that virtual environment, install the ReCirq dependencies using `pip`:
78+
79+
```shell
80+
pip install -r requirements.txt
81+
```
82+
83+
You _may_ need to install additional requirements, depending on the ReCirq
84+
experiment you want to work on. These additional requirements will be in a
85+
file named `extra-requirements.txt` in the experiment's subdirectory under
86+
`recirq/`. For example, if you were working with `recirq/optimize`, you would
87+
need to install its extra dependencies like this:
88+
89+
```shell
90+
pip install -r recirq/optimize/extra-requirements.txt
91+
```
92+
93+
Finally, if you are going to edit any of the Jupyter notebooks, install the
94+
additional requirements needed to run the notebook format checks:
95+
96+
```shell
97+
pip install -r dev_tools/requirements/deps/tensorflow-docs.txt
98+
```
99+
100+
Once the environment is set up, you can do your work and `git commit` your
101+
changes to your branch as needed.
102+
103+
To test notebooks for proper formatting and other issues, run the following
104+
command:
105+
106+
```shell
107+
dev_tools/nbformat
108+
```
109+
110+
To test your code, run
111+
112+
```shell
113+
pytest recirq
114+
```
73115

74116
### Pull requests and code reviews
75117

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@ seaborn
66
sphinx
77
ipython
88
black
9+
pytest

0 commit comments

Comments
 (0)