Skip to content

Pull request workflows fail after wheel workflow changes #311

Description

@danielgaskins

There are two problems with the pull request workflows after #308:

  1. .github/workflows/ci.yml still calls .github/workflows/build-wheels.yml, but that reusable workflow was removed. GitHub rejects ci.yml before any jobs start.
  2. .github/workflows/dry-run-release.yml always attempts TestPyPI publication. Forked pull requests do not receive repository secrets or OIDC publishing credentials, so Publish all wheels fails after the wheel builds and twine check pass.

Both failures are visible on #300 and #301.

A focused fix would remove the stale reusable-workflow job from ci.yml and limit TestPyPI publication in the dry-run workflow to workflow_dispatch. Pull requests would still build and validate the wheels without attempting publication.

I'm happy to handle this one.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions