Request for information regarding ConfigSource and SsmClient

[argenstijn]

The idea is to build an extension (ConfigSource) to read configuration from SSM parameter store.

My question is, what is the best way to create the SSM client. As we are in the configuration phase of an application i cannot (should not) inject the ssm client.

For example. I could create the ssm client myself reusing the AwsConfig aws() like below

@ConfigMapping(prefix = "test.amazon-ssm-config")
@ConfigRoot(phase = ConfigPhase.RUN_TIME)
public interface AmazonSSMConfig {
     
    AwsConfig aws();
    ......
    

and then create the ssmClient.

` private SsmClient createSsmClient() {
var awsConfig = this.config.aws();
var builder = SsmClient.builder();

if (awsConfig.credentials().isPresent()) {
  var providerCfg = awsConfig.credentials().get();
  builder.credentialsProvider(
      providerCfg.type().create(providerCfg, "iapi.amazon-ssm-config.aws"));

}
awsConfig.region().ifPresent(builder::region);
return builder.build();
}`

But maybe you have suggestions on how to do this a better way and i would really like to hear them.

[scrocquesel]

You should read this one, there a sample project at the end with SecretManager client. If you think it would add value as an extension on its own. It could be a good start.

[melloware]

we should either add it as an extension here or add it to this existing one where HashiCorp Vault is: https://github.com/quarkiverse/quarkus-config-extensions

[scrocquesel]

we should either add it as an extension here or add it to this existing one where HashiCorp Vault is: https://github.com/quarkiverse/quarkus-config-extensions

Make sense, some caching logic for example could be reused.

[melloware]

yeah i can't decide which is the better place for it but i feel like people will look at that Config Extensions for places where stuff is. Also the reason is @scrocquesel we literally just copied and pasted all your ConfigSource example into our project to make it work so to me it feels like if everyone is copying and pasting that code it should be an extension!

[melloware]

ok i got my answer the Azure Secrets was in that config extension and they moved it to Azure Services: quarkiverse/quarkus-azure-services#43

So that means we should do the same here and have it as an extension in this project.

[melloware]

we should model it after Azure KeyVault service: https://github.com/quarkiverse/quarkus-azure-services/tree/main/services/azure-keyvault